cleaned IPC samples a bit

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@5433 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

samples/ipc/client.cpp

@@ -9,15 +9,23 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
+// ============================================================================
+// declarations
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// headers
+// ----------------------------------------------------------------------------
+
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__
-#pragma hdrstop
+    #pragma hdrstop
 #endif
 
 #ifndef WX_PRECOMP
-#include "wx/wx.h"
+    #include "wx/wx.h"
 #endif
 
 // Settings common to both executables: determines whether
@@ -31,55 +39,42 @@
 
 #include "client.h"
 
-MyFrame *frame = NULL;
+// ----------------------------------------------------------------------------
+// wxWin macros
+// ----------------------------------------------------------------------------
 
 IMPLEMENT_APP(MyApp)
 
+BEGIN_EVENT_TABLE(MyFrame, wxFrame)
+    EVT_MENU(CLIENT_QUIT, MyFrame::OnExit)
+    EVT_MENU(CLIENT_EXECUTE, MyFrame::OnExecute)
+    EVT_MENU(CLIENT_POKE, MyFrame::OnPoke)
+    EVT_MENU(CLIENT_REQUEST, MyFrame::OnRequest)
+END_EVENT_TABLE()
+
+// ----------------------------------------------------------------------------
+// globals
+// ----------------------------------------------------------------------------
+
 char ipc_buffer[4000];
 wxListBox *the_list = NULL;
 
 MyConnection *the_connection = NULL;
 MyClient *my_client ;
 
+// ============================================================================
+// implementation
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// MyApp
+// ----------------------------------------------------------------------------
+
 // The `main program' equivalent, creating the windows and returning the
 // main frame
 bool MyApp::OnInit()
 {
-  // Create the main frame window
-  frame = new MyFrame(NULL, "Client", wxPoint(400, 0), wxSize(400, 300));
-
-  // Give it an icon
-  frame->SetIcon(wxICON(mondrian));
-
-  // Make a menubar
-  wxMenu *file_menu = new wxMenu;
-
-  file_menu->Append(CLIENT_EXECUTE, "Execute");
-  file_menu->Append(CLIENT_REQUEST, "Request");
-  file_menu->Append(CLIENT_POKE, "Poke");
-  file_menu->Append(CLIENT_QUIT, "Quit");
-
-  wxMenuBar *menu_bar = new wxMenuBar;
-
-  menu_bar->Append(file_menu, "File");
-
-  // Associate the menu bar with the frame
-  frame->SetMenuBar(menu_bar);
-
-  // Make a panel
-  frame->panel = new wxPanel(frame, -1, wxPoint(0, 0), wxSize(400, 250));
-  the_list = new wxListBox(frame->panel, CLIENT_LISTBOX, wxPoint(5, 5), wxSize(150, 120));
-  the_list->Append("Apple");
-  the_list->Append("Pear");
-  the_list->Append("Orange");
-  the_list->Append("Banana");
-  the_list->Append("Fruit");
-
-  frame->panel->Fit();
-  frame->Fit();
-
     wxString server = "4242";
-
 #if wxUSE_DDE_FOR_SAMPLE
     wxString hostName = wxGetHostName();
 #else
@@ -95,44 +90,76 @@ bool MyApp::OnInit()
     my_client = new MyClient;
     the_connection = (MyConnection *)my_client->MakeConnection(hostName, server, "IPC TEST");
 
-  if (!the_connection)
+    while ( !the_connection )
     {
-    wxMessageBox("Failed to make connection to server", "Client Demo Error");
+        if ( wxMessageBox("Failed to make connection to server.\nRetry?",
-#ifdef __WXMSW__
+                          "Client Demo Error",
-//    extern void wxPrintDDEError();
+                          wxICON_ERROR | wxYES_NO | wxCANCEL ) != wxYES )
-//    wxPrintDDEError();
+        {
-#endif
+            // no server
             return FALSE;
         }
+
+        the_connection = (MyConnection *)my_client->MakeConnection(hostName, server, "IPC TEST");
+    }
+
     if (!the_connection->StartAdvise("Item"))
         wxMessageBox("StartAdvise failed", "Client Demo Error");
 
-  frame->Show(TRUE);
+    // Create the main frame window
+    (new MyFrame(NULL, "Client"))->Show(TRUE);
 
     return TRUE;
 }
 
 int MyApp::OnExit()
 {
-    if (my_client)
+    if (the_connection)
-      delete my_client ;
+    {
+        the_connection->Disconnect();
+    }
+
+    // will delete the connection too
+    delete my_client;
 
     return 0;
 }
 
-BEGIN_EVENT_TABLE(MyFrame, wxFrame)
-    EVT_MENU(CLIENT_QUIT, MyFrame::OnExit)
-    EVT_MENU(CLIENT_EXECUTE, MyFrame::OnExecute)
-    EVT_MENU(CLIENT_POKE, MyFrame::OnPoke)
-    EVT_MENU(CLIENT_REQUEST, MyFrame::OnRequest)
-    EVT_CLOSE(MyFrame::OnCloseWindow)
-END_EVENT_TABLE()
-
 // Define my frame constructor
-MyFrame::MyFrame(wxFrame *frame, const wxString& title, const wxPoint& pos, const wxSize& size):
+MyFrame::MyFrame(wxFrame *frame, const wxString& title)
-  wxFrame(frame, -1, title, pos, size)
+        : wxFrame(frame, -1, title)
 {
     panel = NULL;
+
+    // Give it an icon
+    SetIcon(wxICON(mondrian));
+
+    // Make a menubar
+    wxMenu *file_menu = new wxMenu;
+
+    file_menu->Append(CLIENT_EXECUTE, "Execute");
+    file_menu->Append(CLIENT_REQUEST, "Request");
+    file_menu->Append(CLIENT_POKE, "Poke");
+    file_menu->Append(CLIENT_QUIT, "Quit");
+
+    wxMenuBar *menu_bar = new wxMenuBar;
+
+    menu_bar->Append(file_menu, "File");
+
+    // Associate the menu bar with the frame
+    SetMenuBar(menu_bar);
+
+    // Make a panel
+    panel = new wxPanel(this);
+    the_list = new wxListBox(panel, CLIENT_LISTBOX, wxPoint(5, 5));
+    the_list->Append("Apple");
+    the_list->Append("Pear");
+    the_list->Append("Orange");
+    the_list->Append("Banana");
+    the_list->Append("Fruit");
+
+    panel->Fit();
+    Fit();
 }
 
 void MyFrame::OnExecute(wxCommandEvent& event)
@@ -163,36 +190,20 @@ void MyFrame::OnRequest(wxCommandEvent& event)
 
 void MyFrame::OnExit(wxCommandEvent& event)
 {
-  if (the_connection)
+    Close();
-    the_connection->Disconnect();
-
-  this->Destroy();
 }
 
-// Define the behaviour for the frame closing
+wxConnectionBase *MyClient::OnMakeConnection()
-void MyFrame::OnCloseWindow(wxCloseEvent& event)
-{
-  if (the_connection)
-  {
-    the_connection->Disconnect();
-  }
-  this->Destroy();
-}
-
-MyClient::MyClient(void)
-{
-}
-
-wxConnectionBase *MyClient::OnMakeConnection(void)
 {
     return new MyConnection;
 }
 
-MyConnection::MyConnection(void):wxConnection(ipc_buffer, 3999)
+MyConnection::MyConnection()
+            : wxConnection(ipc_buffer, WXSIZEOF(ipc_buffer))
 {
 }
 
-MyConnection::~MyConnection(void)
+MyConnection::~MyConnection()
 {
     the_connection = NULL;
 }
@@ -210,10 +221,9 @@ bool MyConnection::OnAdvise(const wxString& topic, const wxString& item, char *d
 
 bool MyConnection::OnDisconnect()
 {
-    frame->Destroy();
+    wxWindow *win = wxTheApp->GetTopWindow();
-
+    if ( win )
-    the_connection = NULL;
+        win->Destroy();
-    delete this;
 
     return TRUE;
 }

samples/ipc/client.h

@@ -12,39 +12,41 @@
 // Define a new application
 class MyApp: public wxApp
 {
-  public:
+public:
-    bool OnInit();
+    virtual bool OnInit();
-    int OnExit();
+    virtual int OnExit();
 };
 
 // Define a new frame
 class MyFrame: public wxFrame
 {
-  public:
+public:
-    wxPanel *panel;
+    MyFrame(wxFrame *frame, const wxString& title);
 
-    MyFrame(wxFrame *frame, const wxString& title, const wxPoint& pos, const wxSize& size);
-    void OnCloseWindow(wxCloseEvent& event);
     void OnExit(wxCommandEvent& event);
     void OnExecute(wxCommandEvent& event);
     void OnPoke(wxCommandEvent& event);
     void OnRequest(wxCommandEvent& event);
-DECLARE_EVENT_TABLE()
+
+private:
+    wxPanel *panel;
+
+    DECLARE_EVENT_TABLE()
 };
 
 class MyConnection: public wxConnection
 {
- public:
+public:
     MyConnection();
     ~MyConnection();
+
     bool OnAdvise(const wxString& topic, const wxString& item, char *data, int size, wxIPCFormat format);
     bool OnDisconnect();
 };
 
 class MyClient: public wxClient
 {
- public:
+public:
-  MyClient();
     wxConnectionBase *OnMakeConnection();
 };
 

samples/ipc/server.cpp

@@ -1,6 +1,6 @@
 /////////////////////////////////////////////////////////////////////////////
 // Name:        server.cpp
-// Purpose:     DDE sample: server
+// Purpose:     IPC sample: server
 // Author:      Julian Smart
 // Modified by:
 // Created:     25/01/99
@@ -9,45 +9,102 @@
 // Licence:     wxWindows licence
 /////////////////////////////////////////////////////////////////////////////
 
+// ============================================================================
+// declarations
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// headers
+// ----------------------------------------------------------------------------
+
 // For compilers that support precompilation, includes "wx.h".
 #include "wx/wxprec.h"
 
 #ifdef __BORLANDC__
-#pragma hdrstop
+    #pragma hdrstop
 #endif
 
 #ifndef WX_PRECOMP
-#include "wx/wx.h"
+    #include "wx/wx.h"
 #endif
 
 // Settings common to both executables: determines whether
 // we're using TCP/IP or real DDE.
-
 #include "ddesetup.h"
 
 #if defined(__WXGTK__) || defined(__WXMOTIF__)
-#include "mondrian.xpm"
+    #include "mondrian.xpm"
 #endif
 
 #include "server.h"
 
-MyFrame *frame = NULL;
+// ----------------------------------------------------------------------------
+// wxWin macros
+// ----------------------------------------------------------------------------
 
 IMPLEMENT_APP(MyApp)
 
+BEGIN_EVENT_TABLE(MyFrame, wxFrame)
+    EVT_LISTBOX(SERVER_LISTBOX, MyFrame::OnListBoxClick)
+END_EVENT_TABLE()
+
+BEGIN_EVENT_TABLE(IPCDialogBox, wxDialog)
+    EVT_BUTTON(SERVER_QUIT_BUTTON, IPCDialogBox::OnQuit)
+END_EVENT_TABLE()
+
+// ----------------------------------------------------------------------------
+// global variables
+// ----------------------------------------------------------------------------
+
 char ipc_buffer[4000];
 MyConnection *the_connection = NULL;
-MyServer *my_server ;
+
+// ============================================================================
+// implementation
+// ============================================================================
+
+// ----------------------------------------------------------------------------
+// MyApp
+// ----------------------------------------------------------------------------
 
 bool MyApp::OnInit()
 {
     // Create the main frame window
-  frame = new MyFrame(NULL, "Server", wxDefaultPosition, wxSize(400, 500));
+    (new MyFrame(NULL, "Server"))->Show();
 
-  frame->CreateStatusBar();
+    // create the server object
+    wxString server_name = "4242";
+    if (argc > 1)
+        server_name = argv[1];
+
+    // Create a new server
+    m_server = new MyServer;
+    m_server->Create(server_name);
+
+    return TRUE;
+}
+
+int MyApp::OnExit()
+{
+    delete m_server;
+
+    return 0;
+}
+
+// ----------------------------------------------------------------------------
+// MyFrame
+// ----------------------------------------------------------------------------
+
+// Define my frame constructor
+MyFrame::MyFrame(wxFrame *frame, const wxString& title)
+       : wxFrame(frame, -1, title)
+{
+    panel = NULL;
+
+    CreateStatusBar();
 
     // Give it an icon
-  frame->SetIcon(wxICON(mondrian));
+    SetIcon(wxICON(mondrian));
 
     // Make a menubar
     wxMenu *file_menu = new wxMenu;
@@ -59,51 +116,19 @@ bool MyApp::OnInit()
     menu_bar->Append(file_menu, "&File");
 
     // Associate the menu bar with the frame
-  frame->SetMenuBar(menu_bar);
+    SetMenuBar(menu_bar);
 
     // Make a panel
-  frame->panel = new wxPanel(frame, 0, 0, 400, 250);
+    panel = new wxPanel(this);
-  wxListBox *list = new wxListBox(frame->panel, SERVER_LISTBOX,
+    wxListBox *list = new wxListBox(panel, SERVER_LISTBOX, wxPoint(5, 5));
-                                  wxPoint(5, 5), wxSize(150, 120));
     list->Append("Apple");
     list->Append("Pear");
     list->Append("Orange");
     list->Append("Banana");
     list->Append("Fruit");
 
-  frame->panel->Fit();
+    panel->Fit();
-  frame->Fit();
+    Fit();
-
-  wxString server_name = "4242";
-  if (argc > 1)
-    server_name = argv[1];
-
-  // Create a new server
-  my_server = new MyServer;
-  my_server->Create(server_name);
-  frame->Show(TRUE);
-
-  return TRUE;
-}
-
-BEGIN_EVENT_TABLE(MyFrame, wxFrame)
-    EVT_MENU(SERVER_QUIT, MyFrame::OnExit)
-    EVT_CLOSE(MyFrame::OnCloseWindow)
-    EVT_LISTBOX(SERVER_LISTBOX, MyFrame::OnListBoxClick)
-END_EVENT_TABLE()
-
-// Define my frame constructor
-MyFrame::MyFrame(wxFrame *frame, const wxString& title, const wxPoint& pos, const wxSize& size):
-  wxFrame(frame, -1, title, pos, size)
-{
-  panel = NULL;
-}
-
-void MyFrame::OnExit(wxCommandEvent& event)
-{
-    if (my_server)
-        delete my_server;
-    this->Destroy();
 }
 
 // Set the client process's listbox to this item
@@ -115,53 +140,58 @@ void MyFrame::OnListBoxClick(wxCommandEvent& event)
         wxString value = listBox->GetStringSelection();
         if (the_connection)
         {
-            the_connection->Advise("Item", (char*) (const char*) value);
+            the_connection->Advise("Item", (wxChar *)value.c_str());
         }
     }
 }
 
-void MyFrame::OnCloseWindow(wxCloseEvent& event)
+// ----------------------------------------------------------------------------
-{
+// IPCDialogBox
-    if (my_server)
+// ----------------------------------------------------------------------------
-        delete my_server;
-    this->Destroy();
-}
 
-BEGIN_EVENT_TABLE(IPCDialogBox, wxDialog)
+IPCDialogBox::IPCDialogBox(wxWindow *parent, const wxString& title,
-    EVT_BUTTON(SERVER_QUIT_BUTTON, IPCDialogBox::OnQuit)
+                           const wxPoint& pos, const wxSize& size,
-END_EVENT_TABLE()
+                           MyConnection *connection)
-
+            : wxDialog(parent, -1, title, pos, size)
-IPCDialogBox::IPCDialogBox(wxFrame *parent, const wxString& title,
-                         const wxPoint& pos, const wxSize& size, MyConnection *the_connection):
-                     wxDialog(parent, -1, title, pos, size)
 {
-  connection = the_connection;
+    m_connection = connection;
-  (void)new wxButton(this, SERVER_QUIT_BUTTON, "Quit this connection", wxPoint(5, 5));
+    (void)new wxButton(this, SERVER_QUIT_BUTTON, "Quit this connection",
+                       wxPoint(5, 5));
     Fit();
 }
 
 void IPCDialogBox::OnQuit(wxCommandEvent& event)
 {
-  connection->Disconnect();
+    m_connection->Disconnect();
-  delete connection;
+    delete m_connection;
 }
 
+// ----------------------------------------------------------------------------
+// MyServer
+// ----------------------------------------------------------------------------
+
 wxConnectionBase *MyServer::OnAcceptConnection(const wxString& topic)
 {
     if (strcmp(topic, "STDIO") != 0 && strcmp(topic, "IPC TEST") == 0)
-    return new MyConnection(ipc_buffer, 4000);
+        return new MyConnection(ipc_buffer, WXSIZEOF(ipc_buffer));
     else
         return NULL;
 }
 
-MyConnection::MyConnection(char *buf, int size):wxConnection(buf, size)
+// ----------------------------------------------------------------------------
+// MyConnection
+// ----------------------------------------------------------------------------
+
+MyConnection::MyConnection(char *buf, int size)
+            : wxConnection(buf, size)
 {
-  dialog = new IPCDialogBox(frame, "Connection", wxPoint(100, 100), wxSize(500, 500), this);
+    dialog = new IPCDialogBox(wxTheApp->GetTopWindow(), "Connection",
+                              wxPoint(100, 100), wxSize(500, 500), this);
     dialog->Show(TRUE);
     the_connection = this;
 }
 
-MyConnection::~MyConnection(void)
+MyConnection::~MyConnection()
 {
     if (the_connection)
     {
@@ -170,28 +200,35 @@ MyConnection::~MyConnection(void)
     }
 }
 
-bool MyConnection::OnExecute(const wxString& topic, char *data, int size, wxIPCFormat format)
+bool MyConnection::OnExecute(const wxString& WXUNUSED(topic),
+                             char *data,
+                             int WXUNUSED(size),
+                             wxIPCFormat WXUNUSED(format))
 {
-  char buf[300];
+    wxLogStatus("Execute command: %s", data);
-  sprintf(buf, "Execute command: %s", data);
-  frame->SetStatusText(buf);
     return TRUE;
 }
 
-bool MyConnection::OnPoke(const wxString& topic, const wxString& item, char *data, int size, wxIPCFormat format)
+bool MyConnection::OnPoke(const wxString& WXUNUSED(topic),
+                          const wxString& item,
+                          char *data,
+                          int WXUNUSED(size),
+                          wxIPCFormat WXUNUSED(format))
 {
-  char buf[300];
+    wxLogStatus("Poke command: %s = %s", item, data);
-  sprintf(buf, "Poke command: %s", data);
-  frame->SetStatusText(buf);
     return TRUE;
 }
 
-char *MyConnection::OnRequest(const wxString& topic, const wxString& item, int *size, wxIPCFormat format)
+char *MyConnection::OnRequest(const wxString& WXUNUSED(topic),
+                              const wxString& WXUNUSED(item),
+                              int * WXUNUSED(size),
+                              wxIPCFormat WXUNUSED(format))
 {
     return "Here, have your data, client!";
 }
 
-bool MyConnection::OnStartAdvise(const wxString& topic, const wxString& item)
+bool MyConnection::OnStartAdvise(const wxString& WXUNUSED(topic),
+                                 const wxString& WXUNUSED(item))
 {
     return TRUE;
 }

samples/ipc/server.h

@@ -10,34 +10,37 @@
 /////////////////////////////////////////////////////////////////////////////
 
 // Define a new application
-class MyApp: public wxApp
+class MyServer;
+class MyApp : public wxApp
 {
-  public:
+public:
-    bool OnInit();
+    virtual bool OnInit();
+    virtual int OnExit();
+
+private:
+    MyServer *m_server;
 };
 
 DECLARE_APP(MyApp)
 
 // Define a new frame
-class MyFrame: public wxFrame
+class MyFrame : public wxFrame
 {
-  public:
+public:
+    MyFrame(wxFrame *frame, const wxString& title);
+
+    void OnListBoxClick(wxCommandEvent& event);
+
+private:
     wxPanel *panel;
 
-    MyFrame(wxFrame *frame, const wxString& title, const wxPoint& pos, const wxSize& size);
+    DECLARE_EVENT_TABLE()
-
-    void OnCloseWindow(wxCloseEvent& event);
-    void OnExit(wxCommandEvent& event);
-    void OnListBoxClick(wxCommandEvent& event);
-DECLARE_EVENT_TABLE()
 };
 
 class IPCDialogBox;
-class MyConnection: public wxConnection
+class MyConnection : public wxConnection
 {
- public:
+public:
-  IPCDialogBox *dialog;
-
     MyConnection(char *buf, int size);
     ~MyConnection();
 
@@ -45,6 +48,9 @@ class MyConnection: public wxConnection
     char *OnRequest(const wxString& topic, const wxString& item, int *size, wxIPCFormat format);
     bool OnPoke(const wxString& topic, const wxString& item, char *data, int size, wxIPCFormat format);
     bool OnStartAdvise(const wxString& topic, const wxString& item);
+
+private:
+    IPCDialogBox *dialog;
 };
 
 class MyServer: public wxServer
@@ -56,13 +62,18 @@ public:
 class IPCDialogBox: public wxDialog
 {
 public:
-    MyConnection *connection;
+    IPCDialogBox(wxWindow *parent,
-    IPCDialogBox(wxFrame *parent, const wxString& title,
+                 const wxString& title,
-                         const wxPoint& pos, const wxSize& size, MyConnection *the_connection);
+                 const wxPoint& pos,
+                 const wxSize& size,
+                 MyConnection *the_connection);
 
     void OnQuit(wxCommandEvent& event);
 
-DECLARE_EVENT_TABLE()
+private:
+    MyConnection *m_connection;
+
+    DECLARE_EVENT_TABLE()
 };
 
 #define SERVER_QUIT         wxID_EXIT