Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

check that filename pointer is non-NULL before using it, not after (coverity warning); don't pass NULL fp to fclose()

Browse Source 
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@45137 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2007-03-30 13:06:29 +00:00
parent 61011e917f
commit 4b5a7d3d09
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/gtk/assertdlg_gtk.c
View File

@@ -181,18 +181,23 @@ void gtk_assert_dialog_save_backtrace_callback (GtkWidget *widget, GtkAssertDial
FILE *fp; FILE *fp;
filename = gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (dialog)); filename = gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (dialog));
msg = gtk_assert_dialog_get_message (dlg); if ( filename )
backtrace = gtk_assert_dialog_get_backtrace (dlg); {
msg = gtk_assert_dialog_get_message (dlg);
backtrace = gtk_assert_dialog_get_backtrace (dlg);
/* open the file and write all info inside it */ /* open the file and write all info inside it */
fp = fopen (filename, "w"); fp = fopen (filename, "w");
if (fp) if (fp)
fprintf (fp, "ASSERT INFO:\n%s\n\nBACKTRACE:\n%s", msg, backtrace); {
fprintf (fp, "ASSERT INFO:\n%s\n\nBACKTRACE:\n%s", msg, backtrace);
fclose (fp);
}
g_free (filename); g_free (filename);
g_free (msg); g_free (msg);
g_free (backtrace); g_free (backtrace);
fclose (fp); }
} }
gtk_widget_destroy (dialog); gtk_widget_destroy (dialog);