From 466f72a16cc27f2b52b7e54faa34bdc95fed0d3e Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sun, 20 Sep 2020 18:18:36 +0200
Subject: [PATCH] Avoid claling FindToolByPositionWithPacking() needlessly

This is a micro-optimization after the previous commit: don't call
FindToolByPositionWithPacking() at all rather than calling it and then
ignoring its result if wxAUI_TB_NO_TOOLTIPS style is set.

This commit is best viewed ignoring whitespace.
---
 src/aui/auibar.cpp | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/src/aui/auibar.cpp b/src/aui/auibar.cpp
index 01020ce405..b07b2ca296 100644
--- a/src/aui/auibar.cpp
+++ b/src/aui/auibar.cpp
@@ -2874,24 +2874,27 @@ void wxAuiToolBar::OnMotion(wxMouseEvent& evt)
         SetHoverItem(hitItem);
 
         // tooltips handling
-        wxAuiToolBarItem* packingHitItem;
-        packingHitItem = FindToolByPositionWithPacking(evt.GetX(), evt.GetY());
-        if ( !HasFlag(wxAUI_TB_NO_TOOLTIPS) && packingHitItem )
+        if ( !HasFlag(wxAUI_TB_NO_TOOLTIPS) )
         {
-            if (packingHitItem != m_tipItem)
+            wxAuiToolBarItem* packingHitItem;
+            packingHitItem = FindToolByPositionWithPacking(evt.GetX(), evt.GetY());
+            if ( packingHitItem )
             {
-                m_tipItem = packingHitItem;
+                if (packingHitItem != m_tipItem)
+                {
+                    m_tipItem = packingHitItem;
 
-                if ( !packingHitItem->m_shortHelp.empty() )
-                    SetToolTip(packingHitItem->m_shortHelp);
-                else
-                    UnsetToolTip();
+                    if ( !packingHitItem->m_shortHelp.empty() )
+                        SetToolTip(packingHitItem->m_shortHelp);
+                    else
+                        UnsetToolTip();
+                }
+            }
+            else
+            {
+                UnsetToolTip();
+                m_tipItem = NULL;
             }
-        }
-        else
-        {
-            UnsetToolTip();
-            m_tipItem = NULL;
         }
 
         // figure out the dropdown button state (are we hovering or pressing it?)