analyzer warnings: assign [super init] to self and check for nil

2017-06-07 10:21:18 +02:00
parent c6ca6d922f
commit 4312de64c7
15 changed files with 165 additions and 121 deletions
--- a/src/osx/cocoa/notebook.mm
+++ b/src/osx/cocoa/notebook.mm
@@ -112,8 +112,11 @@
@implementation WXCTabViewImageItem : NSTabViewItem
 - (id)init
 {
-    m_image = nil;
-    return [super initWithIdentifier:nil];
+    if (self = [super initWithIdentifier:nil])
+    {
+        m_image = nil;
+    }
+    return self;
 }
 - (void)dealloc
 {