Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix handling of wxSET, wxCLEAR and wxINVERT ROPs in wxMSW.

Browse Source 
Avoid passing source HDC to MaskBlt() for these ROPs which only use the
destination HDC as they produce garbage instead of just ignoring the source in
if it's non-NULL.

Closes #2047.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@75738 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2014-01-29 22:25:56 +00:00
parent afb49a224b
commit 3ded9e191d
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/msw/dc.cpp
View File

@@ -2186,7 +2186,7 @@ bool wxMSWDCImpl::DoStretchBlit(wxCoord xdest, wxCoord ydest,
return false; return false;
} }
const HDC hdcSrc = GetHdcOf(*implSrc); HDC hdcSrc = GetHdcOf(*implSrc);
// if either the source or destination has alpha channel, we must use // if either the source or destination has alpha channel, we must use
// AlphaBlt() as other function don't handle it correctly // AlphaBlt() as other function don't handle it correctly
@@ -2243,6 +2243,16 @@ bool wxMSWDCImpl::DoStretchBlit(wxCoord xdest, wxCoord ydest,
return false; return false;
} }
// Most of the operations involve the source or the pattern, but a few of
// them (and only those few, no other are possible) only use destination
// HDC. For them we must not give a valid source HDC to MaskBlt() as it
// still uses it, somehow, and the result is garbage.
if ( dwRop == BLACKNESS || dwRop == WHITENESS ||
dwRop == DSTINVERT || dwRop == DSTCOPY )
{
hdcSrc = NULL;
}
bool success = false; bool success = false;
if (useMask) if (useMask)