use wxRA_SPECIFY_COLS/ROWS instead of old, deprecated and confusing wxRA_HORIZONTAL/VERTICAL

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@60885 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2009-06-03 22:33:32 +00:00
parent e77669fcee
commit 3998c74b9b
12 changed files with 40 additions and 43 deletions

View File

@@ -37,7 +37,7 @@ public:
int n = 0, int n = 0,
const wxString choices[] = (const wxString *) NULL, const wxString choices[] = (const wxString *) NULL,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -53,7 +53,7 @@ public:
const wxSize& size, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -70,7 +70,7 @@ public:
int n = 0, int n = 0,
const wxString choices[] = (const wxString *) NULL, const wxString choices[] = (const wxString *) NULL,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);
bool Create(wxWindow *parent, bool Create(wxWindow *parent,
@@ -80,7 +80,7 @@ public:
const wxSize& size, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);

View File

@@ -30,7 +30,7 @@ public:
int n = 0, int n = 0,
const wxString choices[] = (const wxString *) NULL, const wxString choices[] = (const wxString *) NULL,
int majorDim = 1, int majorDim = 1,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -46,7 +46,7 @@ public:
const wxSize& size, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 1, int majorDim = 1,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -63,7 +63,7 @@ public:
int n = 0, int n = 0,
const wxString choices[] = (const wxString *) NULL, const wxString choices[] = (const wxString *) NULL,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);
bool Create(wxWindow *parent, bool Create(wxWindow *parent,
@@ -73,7 +73,7 @@ public:
const wxSize& size, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);

View File

@@ -30,7 +30,7 @@ public:
const wxPoint& pos = wxDefaultPosition, const wxPoint& pos = wxDefaultPosition,
const wxSize& size = wxDefaultSize, const wxSize& size = wxDefaultSize,
int n = 0, const wxString choices[] = NULL, int n = 0, const wxString choices[] = NULL,
int majorDim = 0, long style = wxRA_HORIZONTAL, int majorDim = 0, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -44,7 +44,7 @@ public:
const wxPoint& pos, const wxPoint& pos,
const wxSize& size, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, long style = wxRA_HORIZONTAL, int majorDim = 0, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -60,7 +60,7 @@ public:
const wxPoint& pos = wxDefaultPosition, const wxPoint& pos = wxDefaultPosition,
const wxSize& size = wxDefaultSize, const wxSize& size = wxDefaultSize,
int n = 0, const wxString choices[] = NULL, int n = 0, const wxString choices[] = NULL,
int majorDim = 0, long style = wxRA_HORIZONTAL, int majorDim = 0, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);
@@ -68,7 +68,7 @@ public:
const wxPoint& pos, const wxPoint& pos,
const wxSize& size, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, long style = wxRA_HORIZONTAL, int majorDim = 0, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);

View File

@@ -32,7 +32,7 @@ public:
const wxSize& size = wxDefaultSize, const wxSize& size = wxDefaultSize,
int n = 0, const wxString choices[] = NULL, int n = 0, const wxString choices[] = NULL,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -49,7 +49,7 @@ public:
const wxSize& size, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -68,7 +68,7 @@ public:
const wxSize& size = wxDefaultSize, const wxSize& size = wxDefaultSize,
int n = 0, const wxString choices[] = NULL, int n = 0, const wxString choices[] = NULL,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);
bool Create(wxWindow *parent, bool Create(wxWindow *parent,
@@ -78,7 +78,7 @@ public:
const wxSize& size, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, int majorDim = 0,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);

View File

@@ -28,7 +28,7 @@ public:
,int nNum = 0 ,int nNum = 0
,const wxString asChoices[] = NULL ,const wxString asChoices[] = NULL
,int nMajorDim = 0 ,int nMajorDim = 0
,long lStyle = wxRA_HORIZONTAL ,long lStyle = wxRA_SPECIFY_COLS
,const wxValidator& rVal = wxDefaultValidator ,const wxValidator& rVal = wxDefaultValidator
,const wxString& rsName = wxRadioBoxNameStr ,const wxString& rsName = wxRadioBoxNameStr
) )
@@ -54,7 +54,7 @@ public:
,const wxSize& rSize ,const wxSize& rSize
,const wxArrayString& asChoices ,const wxArrayString& asChoices
,int nMajorDim = 0 ,int nMajorDim = 0
,long lStyle = wxRA_HORIZONTAL ,long lStyle = wxRA_SPECIFY_COLS
,const wxValidator& rVal = wxDefaultValidator ,const wxValidator& rVal = wxDefaultValidator
,const wxString& rsName = wxRadioBoxNameStr ,const wxString& rsName = wxRadioBoxNameStr
) )
@@ -82,7 +82,7 @@ public:
,int nNum = 0 ,int nNum = 0
,const wxString asChoices[] = NULL ,const wxString asChoices[] = NULL
,int nMajorDim = 0 ,int nMajorDim = 0
,long lStyle = wxRA_HORIZONTAL ,long lStyle = wxRA_SPECIFY_COLS
,const wxValidator& rVal = wxDefaultValidator ,const wxValidator& rVal = wxDefaultValidator
,const wxString& rsName = wxRadioBoxNameStr ,const wxString& rsName = wxRadioBoxNameStr
); );
@@ -94,7 +94,7 @@ public:
,const wxSize& rSize ,const wxSize& rSize
,const wxArrayString& asChoices ,const wxArrayString& asChoices
,int nMajorDim = 0 ,int nMajorDim = 0
,long lStyle = wxRA_HORIZONTAL ,long lStyle = wxRA_SPECIFY_COLS
,const wxValidator& rVal = wxDefaultValidator ,const wxValidator& rVal = wxDefaultValidator
,const wxString& rsName = wxRadioBoxNameStr ,const wxString& rsName = wxRadioBoxNameStr
); );

View File

@@ -26,7 +26,7 @@ public:
inline wxRadioBox(wxWindow *parent, wxWindowID id, const wxString& title, inline wxRadioBox(wxWindow *parent, wxWindowID id, const wxString& title,
const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxDefaultSize, const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxDefaultSize,
int n = 0, const wxString choices[] = NULL, int n = 0, const wxString choices[] = NULL,
int majorDim = 0, long style = wxRA_HORIZONTAL, int majorDim = 0, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxString& name = wxRadioBoxNameStr) const wxValidator& val = wxDefaultValidator, const wxString& name = wxRadioBoxNameStr)
{ {
Create(parent, id, title, pos, size, n, choices, majorDim, style, val, name); Create(parent, id, title, pos, size, n, choices, majorDim, style, val, name);
@@ -34,7 +34,7 @@ public:
inline wxRadioBox(wxWindow *parent, wxWindowID id, const wxString& title, inline wxRadioBox(wxWindow *parent, wxWindowID id, const wxString& title,
const wxPoint& pos, const wxSize& size, const wxPoint& pos, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, long style = wxRA_HORIZONTAL, int majorDim = 0, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
{ {
@@ -45,12 +45,12 @@ public:
bool Create(wxWindow *parent, wxWindowID id, const wxString& title, bool Create(wxWindow *parent, wxWindowID id, const wxString& title,
const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxDefaultSize, const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxDefaultSize,
int n = 0, const wxString choices[] = NULL, int n = 0, const wxString choices[] = NULL,
int majorDim = 0, long style = wxRA_HORIZONTAL, int majorDim = 0, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxString& name = wxRadioBoxNameStr); const wxValidator& val = wxDefaultValidator, const wxString& name = wxRadioBoxNameStr);
bool Create(wxWindow *parent, wxWindowID id, const wxString& title, bool Create(wxWindow *parent, wxWindowID id, const wxString& title,
const wxPoint& pos, const wxSize& size, const wxPoint& pos, const wxSize& size,
const wxArrayString& choices, const wxArrayString& choices,
int majorDim = 0, long style = wxRA_HORIZONTAL, int majorDim = 0, long style = wxRA_SPECIFY_COLS,
const wxValidator& val = wxDefaultValidator, const wxValidator& val = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr); const wxString& name = wxRadioBoxNameStr);

View File

@@ -301,7 +301,7 @@ public:
const wxSize& size = wxDefaultSize, const wxSize& size = wxDefaultSize,
int n = 0, const wxString choices[] = NULL, int n = 0, const wxString choices[] = NULL,
int majorDim = 1, int majorDim = 1,
long style = wxRA_HORIZONTAL, long style = wxRA_SPECIFY_COLS,
const wxValidator& validator = wxDefaultValidator, const wxValidator& validator = wxDefaultValidator,
const wxString& name = wxRadioBoxNameStr) const wxString& name = wxRadioBoxNameStr)
: wxRadioBox(parent, id, title, pos, size, n, choices, majorDim, : wxRadioBox(parent, id, title, pos, size, n, choices, majorDim,

View File

@@ -122,7 +122,7 @@ protected:
// ------------ // ------------
// the check/radio boxes for styles // the check/radio boxes for styles
wxCheckBox *m_chkVert; wxCheckBox *m_chkSpecifyRows;
wxCheckBox *m_chkEnableItem; wxCheckBox *m_chkEnableItem;
wxCheckBox *m_chkShowItem; wxCheckBox *m_chkShowItem;
wxRadioBox *m_radioDir; wxRadioBox *m_radioDir;
@@ -191,7 +191,7 @@ RadioWidgetsPage::RadioWidgetsPage(WidgetsBookCtrl *book,
: WidgetsPage(book, imaglist, radio_xpm) : WidgetsPage(book, imaglist, radio_xpm)
{ {
// init everything // init everything
m_chkVert = (wxCheckBox *)NULL; m_chkSpecifyRows = (wxCheckBox *)NULL;
m_chkEnableItem = (wxCheckBox *)NULL; m_chkEnableItem = (wxCheckBox *)NULL;
m_chkShowItem = (wxCheckBox *)NULL; m_chkShowItem = (wxCheckBox *)NULL;
@@ -213,7 +213,11 @@ void RadioWidgetsPage::CreateContent()
wxSizer *sizerLeft = new wxStaticBoxSizer(box, wxVERTICAL); wxSizer *sizerLeft = new wxStaticBoxSizer(box, wxVERTICAL);
m_chkVert = CreateCheckBoxAndAddToSizer(sizerLeft, _T("&Vertical layout")); m_chkSpecifyRows = CreateCheckBoxAndAddToSizer
(
sizerLeft,
"Major specifies &rows count"
);
static const wxString layoutDir[] = static const wxString layoutDir[] =
{ {
@@ -315,7 +319,7 @@ void RadioWidgetsPage::Reset()
m_textLabel->SetValue(_T("I'm a radiobox")); m_textLabel->SetValue(_T("I'm a radiobox"));
m_textLabelBtns->SetValue(_T("item")); m_textLabelBtns->SetValue(_T("item"));
m_chkVert->SetValue(false); m_chkSpecifyRows->SetValue(false);
m_chkEnableItem->SetValue(true); m_chkEnableItem->SetValue(true);
m_chkShowItem->SetValue(true); m_chkShowItem->SetValue(true);
m_radioDir->SetSelection(RadioDir_Default); m_radioDir->SetSelection(RadioDir_Default);
@@ -364,8 +368,8 @@ void RadioWidgetsPage::CreateRadio()
labelBtn.c_str(), (unsigned long)n + 1); labelBtn.c_str(), (unsigned long)n + 1);
} }
int flags = m_chkVert->GetValue() ? wxRA_VERTICAL int flags = m_chkSpecifyRows->GetValue() ? wxRA_SPECIFY_ROWS
: wxRA_HORIZONTAL; : wxRA_SPECIFY_COLS;
flags |= ms_defaultFlags; flags |= ms_defaultFlags;
@@ -491,7 +495,7 @@ void RadioWidgetsPage::OnUpdateUISelection(wxUpdateUIEvent& event)
void RadioWidgetsPage::OnUpdateUIReset(wxUpdateUIEvent& event) void RadioWidgetsPage::OnUpdateUIReset(wxUpdateUIEvent& event)
{ {
// only enable it if something is not set to default // only enable it if something is not set to default
bool enable = m_chkVert->GetValue(); bool enable = m_chkSpecifyRows->GetValue();
if ( !enable ) if ( !enable )
{ {

View File

@@ -229,8 +229,7 @@ void wxGenericPrintDialog::Init(wxWindow * WXUNUSED(parent))
{ {
m_rangeRadioBox = new wxRadioBox(this, wxPRINTID_RANGE, _("Print Range"), m_rangeRadioBox = new wxRadioBox(this, wxPRINTID_RANGE, _("Print Range"),
wxDefaultPosition, wxDefaultSize, wxDefaultPosition, wxDefaultSize,
2, choices, 2, choices);
1, wxRA_VERTICAL);
m_rangeRadioBox->SetSelection(1); m_rangeRadioBox->SetSelection(1);
mainsizer->Add( m_rangeRadioBox, 0, wxLEFT|wxTOP|wxRIGHT, 10 ); mainsizer->Add( m_rangeRadioBox, 0, wxLEFT|wxTOP|wxRIGHT, 10 );

View File

@@ -74,10 +74,7 @@ wxBEGIN_FLAGS( wxRadioBoxStyle )
wxFLAGS_MEMBER(wxHSCROLL) wxFLAGS_MEMBER(wxHSCROLL)
wxFLAGS_MEMBER(wxRA_SPECIFY_COLS) wxFLAGS_MEMBER(wxRA_SPECIFY_COLS)
wxFLAGS_MEMBER(wxRA_HORIZONTAL)
wxFLAGS_MEMBER(wxRA_SPECIFY_ROWS) wxFLAGS_MEMBER(wxRA_SPECIFY_ROWS)
wxFLAGS_MEMBER(wxRA_VERTICAL)
wxEND_FLAGS( wxRadioBoxStyle ) wxEND_FLAGS( wxRadioBoxStyle )
IMPLEMENT_DYNAMIC_CLASS_XTI(wxRadioBox, wxControl,"wx/radiobox.h") IMPLEMENT_DYNAMIC_CLASS_XTI(wxRadioBox, wxControl,"wx/radiobox.h")

View File

@@ -73,10 +73,7 @@ wxBEGIN_FLAGS( wxRadioBoxStyle )
wxFLAGS_MEMBER(wxHSCROLL) wxFLAGS_MEMBER(wxHSCROLL)
wxFLAGS_MEMBER(wxRA_SPECIFY_COLS) wxFLAGS_MEMBER(wxRA_SPECIFY_COLS)
wxFLAGS_MEMBER(wxRA_HORIZONTAL)
wxFLAGS_MEMBER(wxRA_SPECIFY_ROWS) wxFLAGS_MEMBER(wxRA_SPECIFY_ROWS)
wxFLAGS_MEMBER(wxRA_VERTICAL)
wxEND_FLAGS( wxRadioBoxStyle ) wxEND_FLAGS( wxRadioBoxStyle )
IMPLEMENT_DYNAMIC_CLASS_XTI(wxRadioBox, wxControl,"wx/radiobox.h") IMPLEMENT_DYNAMIC_CLASS_XTI(wxRadioBox, wxControl,"wx/radiobox.h")

View File

@@ -147,11 +147,11 @@ bool wxRadioBox::Create(wxWindow *parent,
if ( !(style & (wxRA_LEFTTORIGHT | wxRA_TOPTOBOTTOM)) ) if ( !(style & (wxRA_LEFTTORIGHT | wxRA_TOPTOBOTTOM)) )
{ {
// horizontal radiobox use left to right layout // horizontal radiobox use left to right layout
if ( style & wxRA_HORIZONTAL ) if ( style & wxRA_SPECIFY_COLS )
{ {
style |= wxRA_LEFTTORIGHT; style |= wxRA_LEFTTORIGHT;
} }
else if ( style & wxRA_VERTICAL ) else if ( style & wxRA_SPECIFY_ROWS )
{ {
style |= wxRA_TOPTOBOTTOM; style |= wxRA_TOPTOBOTTOM;
} }
@@ -160,7 +160,7 @@ bool wxRadioBox::Create(wxWindow *parent,
wxFAIL_MSG( _T("you must specify wxRA_XXX style!") ); wxFAIL_MSG( _T("you must specify wxRA_XXX style!") );
// use default // use default
style = wxRA_HORIZONTAL | wxRA_LEFTTORIGHT; style = wxRA_SPECIFY_COLS | wxRA_LEFTTORIGHT;
} }
} }