From 3926538fea9b584e3175ee46049ca1e433c70a32 Mon Sep 17 00:00:00 2001 From: Lauri Nurmi Date: Mon, 24 Oct 2016 22:01:34 +0300 Subject: [PATCH] Don't de-capitalize system error messages on MSW The returned string being capitalized is not 'bad' as the ancient comment from the 90s suggested. At least on Windows 7+, system error messages are full sentences beginning with a capital letter, ending in a full stop; there is no point in lowercasing the first letter. --- src/common/log.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/common/log.cpp b/src/common/log.cpp index 35ffb86ba6..c2828ba8f5 100644 --- a/src/common/log.cpp +++ b/src/common/log.cpp @@ -1092,8 +1092,7 @@ const wxChar *wxSysErrorMsg(unsigned long nErrCode) LocalFree(lpMsgBuf); - // returned string is capitalized and ended with '\r\n' - bad - s_szBuf[0] = (wxChar)wxTolower(s_szBuf[0]); + // returned string is ended with '\r\n' - bad size_t len = wxStrlen(s_szBuf); if ( len >= 2 ) { // truncate string