Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

check that the pointer is non-NULL before using it in OpenFile() (thanks coverity)

Browse Source 
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@45138 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2007-03-30 13:11:09 +00:00
parent 4b5a7d3d09
commit 3681c515e2
1 changed files with 19 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/common/fs_arc.cpp
View File

@@ -395,10 +395,17 @@ wxFSFile* wxArchiveFSHandler::OpenFile(
} }
wxArchiveInputStream *s = factory->NewStream(leftStream); wxArchiveInputStream *s = factory->NewStream(leftStream);
if ( !s )
return NULL;
s->OpenEntry(*entry); s->OpenEntry(*entry);
if (s && s->IsOk()) if (!s->IsOk())
{ {
delete s;
return NULL;
}
#if WXWIN_COMPATIBILITY_2_6 #if WXWIN_COMPATIBILITY_2_6
if (factory->IsKindOf(CLASSINFO(wxZipClassFactory))) if (factory->IsKindOf(CLASSINFO(wxZipClassFactory)))
((wxZipInputStream*)s)->m_allowSeeking = true; ((wxZipInputStream*)s)->m_allowSeeking = true;
@@ -414,10 +421,6 @@ wxFSFile* wxArchiveFSHandler::OpenFile(
); );
} }
delete s;
return NULL;
}
wxString wxArchiveFSHandler::FindFirst(const wxString& spec, int flags) wxString wxArchiveFSHandler::FindFirst(const wxString& spec, int flags)
{ {
wxString right = GetRightLocation(spec); wxString right = GetRightLocation(spec);