Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a TODO comment for wxVListBox refactoring

Browse Source 
Just note that it would be better to avoid duplicating the code already
existing in another place in wxVListBoxComboPopup::SendComboBoxEvent().
This commit is contained in:
Vadim Zeitlin
2019-07-21 21:38:59 +02:00
parent cd8dade23c
commit 366233e400
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/generic/odcombo.cpp
View File

@@ -233,6 +233,11 @@ void wxVListBoxComboPopup::DismissWithEvent()
void wxVListBoxComboPopup::SendComboBoxEvent( int selection ) void wxVListBoxComboPopup::SendComboBoxEvent( int selection )
{ {
// TODO: wxVListBox should be refactored to inherit from wxItemContainer
// and then we would be able to just call SendSelectionChangedEvent()
// (which, itself, should be moved down to wxItemContainer from
// wxControlWithItemsBase) instead of duplicating its code.
wxCommandEvent evt(wxEVT_COMBOBOX,m_combo->GetId()); wxCommandEvent evt(wxEVT_COMBOBOX,m_combo->GetId());
evt.SetEventObject(m_combo); evt.SetEventObject(m_combo);