Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a few more BSTR leaks in wxWebViewIE

Browse Source 
Use wxBasicString to ensure that temporary BSTRs are correctly freed.
This commit is contained in:
PB
2017-07-16 23:04:22 +02:00
committed by VZ
parent 54275bb2c9
commit 362b1220b4
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/msw/webview_ie.cpp
View File

@@ -692,9 +692,9 @@ void wxWebViewIE::SetEditable(bool enable)
if(document) if(document)
{ {
if( enable ) if( enable )
document->put_designMode(SysAllocString(L"On")); document->put_designMode(wxBasicString("On"));
else else
document->put_designMode(SysAllocString(L"Off")); document->put_designMode(wxBasicString("Off"));
} }
} }
@@ -867,8 +867,8 @@ void wxWebViewIE::RunScript(const wxString& javascript)
VARIANT level; VARIANT level;
VariantInit(&level); VariantInit(&level);
V_VT(&level) = VT_EMPTY; V_VT(&level) = VT_EMPTY;
window->execScript(SysAllocString(javascript.wc_str()), window->execScript(wxBasicString(javascript),
SysAllocString(language.wc_str()), wxBasicString(language),
&level); &level);
} }
} }
@@ -913,7 +913,7 @@ bool wxWebViewIE::CanExecCommand(wxString command) const
{ {
VARIANT_BOOL enabled; VARIANT_BOOL enabled;
document->queryCommandEnabled(SysAllocString(command.wc_str()), &enabled); document->queryCommandEnabled(wxBasicString(command), &enabled);
return (enabled == VARIANT_TRUE); return (enabled == VARIANT_TRUE);
} }
@@ -930,7 +930,7 @@ void wxWebViewIE::ExecCommand(wxString command)
if(document) if(document)
{ {
document->execCommand(SysAllocString(command.wc_str()), VARIANT_FALSE, VARIANT(), NULL); document->execCommand(wxBasicString(command), VARIANT_FALSE, VARIANT(), NULL);
} }
} }