Make wxGridCellAttr ctor taking a single argument explicit

There doesn't seem to be any reason for allowing to implicitly convert
wxGridCellAttr pointer to wxGridCellAttr object.
This commit is contained in:
Vadim Zeitlin
2020-01-11 14:03:54 +01:00
parent 59111e0d11
commit 325408f062
3 changed files with 7 additions and 5 deletions

View File

@@ -146,6 +146,8 @@ Changes in behaviour which may result in build errors
- wxIntProperty::DoValidation() and wxFloatProperty::DoValidation() are - wxIntProperty::DoValidation() and wxFloatProperty::DoValidation() are
no longer public since they are helpers intended for internal use only. no longer public since they are helpers intended for internal use only.
- wxGridCellAttr ctor taking wxGridCellAttr pointer is now explicit.
3.1.4: (released ????-??-??) 3.1.4: (released ????-??-??)
---------------------------- ----------------------------

View File

@@ -428,16 +428,15 @@ public:
Merged Merged
}; };
// ctors // default ctor
wxGridCellAttr(wxGridCellAttr *attrDefault = NULL) explicit wxGridCellAttr(wxGridCellAttr *attrDefault = NULL)
{ {
Init(attrDefault); Init(attrDefault);
SetAlignment(wxALIGN_INVALID, wxALIGN_INVALID); SetAlignment(wxALIGN_INVALID, wxALIGN_INVALID);
} }
// VZ: considering the number of members wxGridCellAttr has now, this ctor // ctor setting the most common attributes
// seems to be pretty useless... may be we should just remove it?
wxGridCellAttr(const wxColour& colText, wxGridCellAttr(const wxColour& colText,
const wxColour& colBack, const wxColour& colBack,
const wxFont& font, const wxFont& font,

View File

@@ -912,7 +912,8 @@ public:
/** /**
Default constructor. Default constructor.
*/ */
wxGridCellAttr(wxGridCellAttr* attrDefault = NULL); explicit wxGridCellAttr(wxGridCellAttr* attrDefault = NULL);
/** /**
Constructor specifying some of the often used attributes. Constructor specifying some of the often used attributes.
*/ */