From 2ec97b7bc6d562c0fb99b62a68bf3e12564c4de1 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Tue, 29 May 2018 13:24:09 +0200 Subject: [PATCH] Remove useless border style check from wxVListBox::Create() The comparison could never be true as wxDEFAULT is not one of wxBORDER_XXX values and so is not included in wxBORDER_MASK and so was useless -- and just results in -Wtautological-compare from gcc 8. Simply remove this check, a047aff270905b377a81657a90f92eb3297157d0 added it apparently to use themed border by default for wxVListBox, but this was done in a better way in 28319afe559ccc061d15e5a5cb7208959f5c771e. --- src/generic/vlbox.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/generic/vlbox.cpp b/src/generic/vlbox.cpp index 9efeccdaf7..4aabd378ad 100644 --- a/src/generic/vlbox.cpp +++ b/src/generic/vlbox.cpp @@ -79,11 +79,6 @@ bool wxVListBox::Create(wxWindow *parent, long style, const wxString& name) { -#ifdef __WXMSW__ - if ( (style & wxBORDER_MASK) == wxDEFAULT ) - style |= wxBORDER_THEME; -#endif - style |= wxWANTS_CHARS | wxFULL_REPAINT_ON_RESIZE; if ( !wxVScrolledWindow::Create(parent, id, pos, size, style, name) ) return false;