No real changes, just refactor wxControlContainer code a little.

Extract the call to wxWindow::SetCanFocus() into a separate
UpdateParentCanFocus() function as it can be necessary to do it from places
other than UpdateCanFocusChildren() too.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74582 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2013-07-23 00:43:29 +00:00
parent da6239561d
commit 2c750daecd
2 changed files with 12 additions and 4 deletions

View File

@@ -97,6 +97,9 @@ protected:
wxWindow *m_winLastFocused; wxWindow *m_winLastFocused;
private: private:
// Update the window status to reflect whether it is getting focus or not.
void UpdateParentCanFocus();
// Indicates whether the associated window can ever have focus itself. // Indicates whether the associated window can ever have focus itself.
// //
// Usually this is the case, e.g. a wxPanel can be used either as a // Usually this is the case, e.g. a wxPanel can be used either as a

View File

@@ -47,6 +47,14 @@
// wxControlContainerBase // wxControlContainerBase
// ---------------------------------------------------------------------------- // ----------------------------------------------------------------------------
void wxControlContainerBase::UpdateParentCanFocus()
{
// In the ports where it does something non trivial, the parent window
// should only be focusable if it doesn't have any focusable children
// (e.g. native focus handling in wxGTK totally breaks down otherwise).
m_winParent->SetCanFocus(m_acceptsFocusSelf && !m_acceptsFocusChildren);
}
bool wxControlContainerBase::UpdateCanFocusChildren() bool wxControlContainerBase::UpdateCanFocusChildren()
{ {
const bool acceptsFocusChildren = HasAnyFocusableChildren(); const bool acceptsFocusChildren = HasAnyFocusableChildren();
@@ -54,10 +62,7 @@ bool wxControlContainerBase::UpdateCanFocusChildren()
{ {
m_acceptsFocusChildren = acceptsFocusChildren; m_acceptsFocusChildren = acceptsFocusChildren;
// In the ports where it does something non trivial, the parent window UpdateParentCanFocus();
// should only be focusable if it doesn't have any focusable children
// (e.g. native focus handling in wxGTK totally breaks down otherwise).
m_winParent->SetCanFocus(m_acceptsFocusSelf && !m_acceptsFocusChildren);
} }
return m_acceptsFocusChildren; return m_acceptsFocusChildren;