Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dirty fix for even dirtier memory leak

Browse Source 
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@14762 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Václav Slavík
2002-03-24 15:50:57 +00:00
parent 733342af30
commit 2bc524f358
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
samples/html/virtual/virtual.cpp
View File

@@ -54,7 +54,7 @@ wxFSFile* MyVFS::OpenFile(wxFileSystem& fs, const wxString& location)
{ {
wxFSFile *f; wxFSFile *f;
wxInputStream *str; wxInputStream *str;
char *buf = (char*)malloc(1024); static char buf[1024];
sprintf(buf, "<html><body><h2><i>You're in Node <u>%s</u></i></h2><p>" sprintf(buf, "<html><body><h2><i>You're in Node <u>%s</u></i></h2><p>"
"Where do you want to go?<br><blockquote>" "Where do you want to go?<br><blockquote>"
@@ -64,10 +64,14 @@ wxFSFile* MyVFS::OpenFile(wxFileSystem& fs, const wxString& location)
"</blockquote></body></html>", "</blockquote></body></html>",
location.GetData(), location.GetData(), location.GetData(), location.GetData()); location.GetData(), location.GetData(), location.GetData(), location.GetData());
// WARNING: wxMemoryInputStream will not free buf. // NB: There's a terrible hack involved: we fill 'buf' with new data every
// There is a memory leak here. // time this method is called and return new wxMemoryInputStream pointing to it.
// This won't work as soon as there are 2+ myVFS files opened. Fortunately,
// this won't happen because wxHTML keeps only one "page" file opened at the
// time.
str = new wxMemoryInputStream(buf, strlen(buf)); str = new wxMemoryInputStream(buf, strlen(buf));
f = new wxFSFile(str, location, "text/html", wxEmptyString, wxDateTime::Today()); f = new wxFSFile(str, location, "text/html", wxEmptyString, wxDateTime::Today());
return f; return f;
} }