From 2b72d94af0a0da04778b2899010a05acf0786d07 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 5 Feb 2022 16:16:38 +0000 Subject: [PATCH] Fix using dangling pointer in artprov sample Don't cast wxString pointer to const char*, this could never work and didn't crash only by some miracle. --- samples/artprov/artbrows.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/samples/artprov/artbrows.cpp b/samples/artprov/artbrows.cpp index 04e1542542..e33319c348 100644 --- a/samples/artprov/artbrows.cpp +++ b/samples/artprov/artbrows.cpp @@ -229,7 +229,9 @@ void wxArtBrowserDialog::SetArtClient(const wxArtClient& client) m_list->SetItemState(sel, wxLIST_STATE_FOCUSED, wxLIST_STATE_FOCUSED); m_client = client; - SetArtBitmap((const char*)m_list->GetItemData(sel), m_client); + + const wxString *data = (const wxString*)m_list->GetItemData(sel); + SetArtBitmap(*data, m_client); } void wxArtBrowserDialog::OnSelectItem(wxListEvent &event)