From 2558c91ae8440c4264f3f7e2a2c023755b8906be Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 19 Nov 2017 22:44:57 +0100 Subject: [PATCH] Don't fail to okay all mono WAVs in OSS wxSound backend Ever since the changes of 544c4a3bdea365dbefd72bea3c0c4568cf03845a (almost 14 years ago), playing mono WAVs with wxSound completely failed if setting the sound device to mono using SNDCTL_DSP_STEREO ioctl failed. This doesn't look like a wise thing to do, so don't consider this as a fatal failure, but just play mono as stereo (and even possibly stereo as mono) instead. This fixes the sound sample being broken out of the box on many (all?) Linux systems. --- src/unix/sound.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/unix/sound.cpp b/src/unix/sound.cpp index ccecdc7e0d..ae38289009 100644 --- a/src/unix/sound.cpp +++ b/src/unix/sound.cpp @@ -224,7 +224,6 @@ bool wxSoundBackendOSS::InitDSP(int dev, const wxSoundData *data) if (tmp != stereo) { wxLogTrace(wxT("sound"), wxT("Unable to set DSP to %s."), stereo? wxT("stereo"):wxT("mono")); - m_needConversion = true; } tmp = data->m_samplingRate;