From 23caf6fe0023b4cae60bafc2568aacb57856b2e7 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Thu, 7 Dec 2017 18:49:59 +0100 Subject: [PATCH] Remove misleading comment from wxStaticBox::PaintBackground() We do use wxStaticBox colour for painting its background (as can be seen with test code from #18018, for example) under MSW, so don't say that we don't. Also, the reasons for not doing it mentioned in the comment are either obsolete (wxGTK3 does do it too, unlike wxGTK2) or lost (the link to the mailing list message doesn't work any longer and can't be recovered). Closes #17913. --- src/msw/statbox.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/msw/statbox.cpp b/src/msw/statbox.cpp index 5adc32ee65..5ba29f58f6 100644 --- a/src/msw/statbox.cpp +++ b/src/msw/statbox.cpp @@ -374,14 +374,6 @@ WXHRGN wxStaticBox::MSWGetRegionWithoutChildren() // do anything in such case) void wxStaticBox::PaintBackground(wxDC& dc, const RECT& rc) { - // note that we do not use the box background colour here, it shouldn't - // apply to its interior for several reasons: - // 1. wxGTK doesn't do it - // 2. controls inside the box don't get correct bg colour because they - // are not our children so we'd have some really ugly colour mix if - // we did it - // 3. this is backwards compatible behaviour and some people rely on it, - // see http://groups.google.com/groups?selm=4252E932.3080801%40able.es wxMSWDCImpl *impl = (wxMSWDCImpl*) dc.GetImpl(); HBRUSH hbr = MSWGetBgBrush(impl->GetHDC());