From 2392423f390e9609a75c0c38b2c784e9edae2094 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 20 Mar 2016 16:59:09 +0100 Subject: [PATCH] Fix wrong calls to wxWindow::Refresh() in OS X wxRenderer Refresh(&rect) was used instead of Refresh(true, &rect) mistakenly, thanks to clang for warning about always-true-conversion-to-bool here. Fix this by using less error-prone and more clear RefreshRect(). --- src/osx/carbon/renderer.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/osx/carbon/renderer.cpp b/src/osx/carbon/renderer.cpp index 8110275f43..6d7d52a360 100644 --- a/src/osx/carbon/renderer.cpp +++ b/src/osx/carbon/renderer.cpp @@ -182,7 +182,7 @@ int wxRendererMac::DrawHeaderButton( wxWindow *win, HIRect headerRect = CGRectMake( x, y, w, h ); if ( !wxHasCGContext(win, dc) ) { - win->Refresh( &rect ); + win->RefreshRect(rect); } else { @@ -271,7 +271,7 @@ void wxRendererMac::DrawTreeItemButton( wxWindow *win, HIRect headerRect = CGRectMake( x, y, w, h ); if ( !wxHasCGContext(win, dc) ) { - win->Refresh( &rect ); + win->RefreshRect(rect); } else { @@ -423,7 +423,7 @@ wxRendererMac::DrawMacThemeButton(wxWindow *win, HIRect headerRect = CGRectMake( x, y, w, h ); if ( !wxHasCGContext(win, dc) ) { - win->Refresh( &rect ); + win->RefreshRect(rect); } else { @@ -668,7 +668,7 @@ void wxRendererMac::DrawTextCtrl(wxWindow* win, wxDC& dc, HIRect hiRect = CGRectMake( x, y, w, h ); if ( !wxHasCGContext(win, dc) ) { - win->Refresh( &rect ); + win->RefreshRect(rect); } else {