Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid copying POST data in NSURLSession wxWebRequest code

Browse Source 
Just give the ownership of the buffer to NSData instead of copying it.
This commit is contained in:
Vadim Zeitlin
2021-01-12 02:34:18 +01:00
parent 5713d17ab0
commit 228d231753
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/osx/webrequest_urlsession.mm
View File

@@ -125,11 +125,11 @@ void wxWebRequestURLSession::Start()
if (m_dataSize) if (m_dataSize)
{ {
// Read all upload data to memory buffer // Read all upload data to memory buffer
wxMemoryBuffer memBuf; void* const buf = malloc(m_dataSize);
m_dataStream->Read(memBuf.GetWriteBuf(m_dataSize), m_dataSize); m_dataStream->Read(buf, m_dataSize);
// Create NSData from memory buffer // Create NSData from memory buffer, passing it ownership of the data.
NSData* data = [NSData dataWithBytes:memBuf.GetData() length:m_dataSize]; NSData* data = [NSData dataWithBytesNoCopy:buf length:m_dataSize];
m_task = [[m_sessionImpl.GetSession() uploadTaskWithRequest:req fromData:data] retain]; m_task = [[m_sessionImpl.GetSession() uploadTaskWithRequest:req fromData:data] retain];
} }
else else