From 2034f6683b753f4a912477683972ab93d175c34c Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 9 Jul 2018 00:24:35 +0200 Subject: [PATCH] Disable use of wxSecretStore with wxGTK1 libsecret is for GTK+ 2+ only and can't be used with GTK+ 1. --- configure | 20 ++++++-------------- configure.in | 5 ++++- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/configure b/configure index 1b11ac5dc3..779605646c 100755 --- a/configure +++ b/configure @@ -1040,7 +1040,6 @@ infodir docdir oldincludedir includedir -runstatedir localstatedir sharedstatedir sysconfdir @@ -1461,7 +1460,6 @@ datadir='${datarootdir}' sysconfdir='${prefix}/etc' sharedstatedir='${prefix}/com' localstatedir='${prefix}/var' -runstatedir='${localstatedir}/run' includedir='${prefix}/include' oldincludedir='/usr/include' docdir='${datarootdir}/doc/${PACKAGE_TARNAME}' @@ -1714,15 +1712,6 @@ do | -silent | --silent | --silen | --sile | --sil) silent=yes ;; - -runstatedir | --runstatedir | --runstatedi | --runstated \ - | --runstate | --runstat | --runsta | --runst | --runs \ - | --run | --ru | --r) - ac_prev=runstatedir ;; - -runstatedir=* | --runstatedir=* | --runstatedi=* | --runstated=* \ - | --runstate=* | --runstat=* | --runsta=* | --runst=* | --runs=* \ - | --run=* | --ru=* | --r=*) - runstatedir=$ac_optarg ;; - -sbindir | --sbindir | --sbindi | --sbind | --sbin | --sbi | --sb) ac_prev=sbindir ;; -sbindir=* | --sbindir=* | --sbindi=* | --sbind=* | --sbin=* \ @@ -1860,7 +1849,7 @@ fi for ac_var in exec_prefix prefix bindir sbindir libexecdir datarootdir \ datadir sysconfdir sharedstatedir localstatedir includedir \ oldincludedir docdir infodir htmldir dvidir pdfdir psdir \ - libdir localedir mandir runstatedir + libdir localedir mandir do eval ac_val=\$$ac_var # Remove trailing slashes. @@ -2013,7 +2002,6 @@ Fine tuning of the installation directories: --sysconfdir=DIR read-only single-machine data [PREFIX/etc] --sharedstatedir=DIR modifiable architecture-independent data [PREFIX/com] --localstatedir=DIR modifiable single-machine data [PREFIX/var] - --runstatedir=DIR modifiable per-process data [LOCALSTATEDIR/run] --libdir=DIR object code libraries [EPREFIX/lib] --includedir=DIR C header files [PREFIX/include] --oldincludedir=DIR C header files for non-gcc [/usr/include] @@ -34150,7 +34138,11 @@ fi if test "$wxUSE_SECRETSTORE" = "yes"; then - if test "$wxUSE_MSW" != "1" -a "$wxUSE_OSX_COCOA" != 1; then + if test "$WXGTK1" = "1"; then + { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: libsecret is incompatible with GTK+ 1, disabled" >&5 +$as_echo "$as_me: WARNING: libsecret is incompatible with GTK+ 1, disabled" >&2;} + wxUSE_SECRETSTORE=no + elif test "$wxUSE_MSW" != "1" -a "$wxUSE_OSX_COCOA" != 1; then pkg_failed=no { $as_echo "$as_me:${as_lineno-$LINENO}: checking for LIBSECRET" >&5 diff --git a/configure.in b/configure.in index cbd7392216..7720f2f5d9 100644 --- a/configure.in +++ b/configure.in @@ -5419,7 +5419,10 @@ dnl --------------------------------------------------------------------------- if test "$wxUSE_SECRETSTORE" = "yes"; then dnl The required APIs are always available under MSW and OS X but we must dnl have GNOME libsecret under Unix to be able to compile this class. - if test "$wxUSE_MSW" != "1" -a "$wxUSE_OSX_COCOA" != 1; then + if test "$WXGTK1" = "1"; then + AC_MSG_WARN([libsecret is incompatible with GTK+ 1, disabled]) + wxUSE_SECRETSTORE=no + elif test "$wxUSE_MSW" != "1" -a "$wxUSE_OSX_COCOA" != 1; then PKG_CHECK_MODULES(LIBSECRET, [libsecret-1], [ CXXFLAGS="$LIBSECRET_CFLAGS $CXXFLAGS"