Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add more wxRound() compatibility overloads and improve docs

Browse Source 
Make the overloads added for compatibility available only when
WXWIN_COMPATIBILITY_3_0 is on and add two more of them, to cover all the
interer types (except char but, honestly, who rounds those?).

Also improve the documentation and make it clear that this function is
not needed at all in the new code.

Closes https://github.com/wxWidgets/wxWidgets/pull/2111
This commit is contained in:
Vadim Zeitlin
2020-11-05 23:13:09 +01:00
parent 52138fc1f1
commit 1cf7c47934
2 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
include/wx/math.h
View File

@@ -164,9 +164,21 @@ inline int wxRound(float x)
inline int wxRound(long double x) { return wxRound(double(x)); }
// For compatibility purposes, define wxRound() overloads for integer types
// too, as this used to compile with wx 3.0.
#if WXWIN_COMPATIBILITY_3_0
wxDEPRECATED_MSG("rounding an integer is useless")
inline int wxRound(int x) { return x; }
wxDEPRECATED_MSG("rounding an integer is useless")
inline int wxRound(short x) { return x; }
wxDEPRECATED_MSG("rounding an integer is useless")
inline int wxRound(long x) { return static_cast<int>(x); }
#endif // WXWIN_COMPATIBILITY_3_0
// Convert between degrees and radians.
inline double wxDegToRad(double deg) { return (deg * M_PI) / 180.0; }
inline double wxRadToDeg(double rad) { return (rad * 180.0) / M_PI; }