From 1bf6d5e18869c4511dc0a7ed27c346bf0cb96721 Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sat, 16 Jan 2021 14:49:25 +0100
Subject: [PATCH] Slightly refactor wxWebRequestImpl::ProcessStateEvent()

Call GetResponse() only once.

Also put the code for State_Completed inside the case for this state in
the switch instead of testing for it separately later.

No real changes.
---
 src/common/webrequest.cpp | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/src/common/webrequest.cpp b/src/common/webrequest.cpp
index f2701029ab..f38824f691 100644
--- a/src/common/webrequest.cpp
+++ b/src/common/webrequest.cpp
@@ -299,6 +299,13 @@ SplitParameters(const wxString& s, wxWebRequestHeaderMap& parameters)
 
 void wxWebRequestImpl::ProcessStateEvent(wxWebRequest::State state, const wxString& failMsg)
 {
+    wxString dataFile;
+
+    const wxWebResponseImplPtr& response = GetResponse();
+
+    wxWebRequestEvent evt(wxEVT_WEBREQUEST_STATE, GetId(), state,
+                          wxWebResponse(response), failMsg);
+
     switch ( state )
     {
         case wxWebRequest::State_Idle:
@@ -310,23 +317,20 @@ void wxWebRequestImpl::ProcessStateEvent(wxWebRequest::State state, const wxStri
             break;
 
         case wxWebRequest::State_Completed:
+            if ( m_storage == wxWebRequest::Storage_File )
+            {
+                dataFile = response->GetDataFile();
+                evt.SetDataFile(dataFile);
+            }
+            wxFALLTHROUGH;
+
         case wxWebRequest::State_Failed:
         case wxWebRequest::State_Cancelled:
-            if ( GetResponse() )
-                GetResponse()->Finalize();
+            if ( response )
+                response->Finalize();
             break;
     }
 
-    wxString dataFile;
-
-    wxWebRequestEvent evt(wxEVT_WEBREQUEST_STATE, GetId(), state,
-        wxWebResponse(GetResponse()), failMsg);
-    if ( state == wxWebRequest::State_Completed && m_storage == wxWebRequest::Storage_File )
-    {
-        dataFile = GetResponse()->GetDataFile();
-        evt.SetDataFile(dataFile);
-    }
-
     m_handler->ProcessEvent(evt);
 
     // Remove temporary file if we're using one and if it still exists: it