Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid reading uninitialized member variable

Browse Source 
m_historyLimit is unused with webkit2
This commit is contained in:
Paul Cornett
2017-06-15 09:04:05 -07:00
parent b9c9fc3534
commit 188b249467
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/gtk/webview_webkit2.cpp
View File

@@ -665,8 +665,7 @@ wxVector<wxSharedPtr<wxWebViewHistoryItem> > wxWebViewWebKit::GetBackwardHistory
wxVector<wxSharedPtr<wxWebViewHistoryItem> > backhist; wxVector<wxSharedPtr<wxWebViewHistoryItem> > backhist;
WebKitBackForwardList* history = WebKitBackForwardList* history =
webkit_web_view_get_back_forward_list(m_web_view); webkit_web_view_get_back_forward_list(m_web_view);
GList* list = webkit_back_forward_list_get_back_list_with_limit(history, GList* list = webkit_back_forward_list_get_back_list(history);
m_historyLimit);
//We need to iterate in reverse to get the order we desire //We need to iterate in reverse to get the order we desire
for(int i = g_list_length(list) - 1; i >= 0 ; i--) for(int i = g_list_length(list) - 1; i >= 0 ; i--)
{ {
@@ -686,8 +685,7 @@ wxVector<wxSharedPtr<wxWebViewHistoryItem> > wxWebViewWebKit::GetForwardHistory(
wxVector<wxSharedPtr<wxWebViewHistoryItem> > forwardhist; wxVector<wxSharedPtr<wxWebViewHistoryItem> > forwardhist;
WebKitBackForwardList* history = WebKitBackForwardList* history =
webkit_web_view_get_back_forward_list(m_web_view); webkit_web_view_get_back_forward_list(m_web_view);
GList* list = webkit_back_forward_list_get_forward_list_with_limit(history, GList* list = webkit_back_forward_list_get_forward_list(history);
m_historyLimit);
for(guint i = 0; i < g_list_length(list); i++) for(guint i = 0; i < g_list_length(list); i++)
{ {
WebKitBackForwardListItem* gtkitem = (WebKitBackForwardListItem*)g_list_nth_data(list, i); WebKitBackForwardListItem* gtkitem = (WebKitBackForwardListItem*)g_list_nth_data(list, i);