Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash due to missing retain in wxUILocale wxMac code

Browse Source 
We need to retain [NSLocale availableLocaleIdentifiers] result too, as
it doesn't copy the returned object.
This commit is contained in:
Vadim Zeitlin
2021-09-10 19:11:42 +02:00
parent b3f609781e
commit 178ac74596
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/osx/core/uilocale.mm
View File

@@ -86,7 +86,7 @@ public:
// completely invalid strings, so we need to check if the name is // completely invalid strings, so we need to check if the name is
// actually in the list of the supported locales ourselves. // actually in the list of the supported locales ourselves.
static wxCFRef<CFArrayRef> static wxCFRef<CFArrayRef>
all((CFArrayRef)[NSLocale availableLocaleIdentifiers]); all((CFArrayRef)[[NSLocale availableLocaleIdentifiers] retain]);
wxCFStringRef cfName(locId.GetName()); wxCFStringRef cfName(locId.GetName());
if ( ![(NSArray*)all.get() containsObject: cfName.AsNSString()] ) if ( ![(NSArray*)all.get() containsObject: cfName.AsNSString()] )