Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use symbolic constant instead of hardcoded 15/85%

Browse Source 
It's still hardcoded, but now it has a name, which explains what it is
and can be searched for.

No real changes.
This commit is contained in:
Vadim Zeitlin
2020-05-03 20:56:59 +02:00
parent 013cacee4d
commit 155e2beafd
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/generic/datavgen.cpp
View File

@@ -2165,7 +2165,11 @@ wxDataViewMainWindow::DropItemInfo wxDataViewMainWindow::GetDropItemInfo(const w
const int itemStart = GetLineStart(row); const int itemStart = GetLineStart(row);
const int itemHeight = GetLineHeight(row); const int itemHeight = GetLineHeight(row);
bool insertAbove = yy - itemStart < itemHeight*0.15; // 15%, TODO: configurable // 15% is an arbitrarily chosen threshold here, which could be changed
// or made configurable if really needed.
static const double UPPER_ITEM_PART = 0.15;
bool insertAbove = yy - itemStart < itemHeight*UPPER_ITEM_PART;
if (insertAbove) if (insertAbove)
{ {
// Can be treated as 'insertBelow" with the small difference: // Can be treated as 'insertBelow" with the small difference:
@@ -2186,7 +2190,7 @@ wxDataViewMainWindow::DropItemInfo wxDataViewMainWindow::GetDropItemInfo(const w
} }
bool insertBelow = yy - itemStart > itemHeight*0.85; // 15%, TODO: configurable bool insertBelow = yy - itemStart > itemHeight*(1.0 - UPPER_ITEM_PART);
if (insertBelow) if (insertBelow)
dropItemInfo.m_hint = DropHint_Below; dropItemInfo.m_hint = DropHint_Below;