From 0d00af59135768d4df4841db24a050a80eef5d1a Mon Sep 17 00:00:00 2001 From: Tobias Taschner Date: Wed, 15 Jan 2020 17:04:51 +0100 Subject: [PATCH] Add wxLogApiError() to important WebView2 API calls --- src/msw/webview_edge.cpp | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/msw/webview_edge.cpp b/src/msw/webview_edge.cpp index e0592ed123..f7078f85b4 100644 --- a/src/msw/webview_edge.cpp +++ b/src/msw/webview_edge.cpp @@ -78,11 +78,14 @@ bool wxWebViewEdge::Initialize() // Check if a Edge browser can be found by the loader DLL LPWSTR versionStr; - if (SUCCEEDED(wxGetWebView2BrowserVersionInfo(NULL, &versionStr))) + HRESULT hr = wxGetWebView2BrowserVersionInfo(NULL, &versionStr); + if (SUCCEEDED(hr)) { if (versionStr) return true; } + else + wxLogApiError("GetWebView2BrowserVersionInfo", hr); return false; } @@ -157,7 +160,12 @@ bool wxWebViewEdge::Create(wxWindow* parent, .Get()); return S_OK; }).Get()); - return SUCCEEDED(hr); + if (FAILED(hr)) + { + wxLogApiError("CreateWebView2EnvironmentWithDetails", hr); + } + else + return true; } void wxWebViewEdge::InitWebViewCtrl() @@ -676,7 +684,13 @@ bool wxWebViewEdge::RunScriptSync(const wxString& javascript, wxString* output) while (!scriptExecuted) wxYield(); - return SUCCEEDED(hr); + if (FAILED(hr)) + { + wxLogApiError("ExecuteScript", hr); + return false; + } + else + return true; } bool wxWebViewEdge::RunScript(const wxString& javascript, wxString* output)