Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove useless wxWebAuthChallengeCURL::Init()

Browse Source 
This just always returned true, so simply remove it to simplify the
code.
This commit is contained in:
Vadim Zeitlin
2021-01-12 19:15:37 +01:00
parent 5e8a14ff41
commit 0ccc6d4047
2 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/wx/private/webrequest_curl.h
View File

@@ -29,8 +29,6 @@ public:
wxWebAuthChallengeCURL(wxWebAuthChallenge::Source source, wxWebAuthChallengeCURL(wxWebAuthChallenge::Source source,
wxWebRequestCURL& request); wxWebRequestCURL& request);
bool Init();
void SetCredentials(const wxWebCredentials& cred) wxOVERRIDE; void SetCredentials(const wxWebCredentials& cred) wxOVERRIDE;
private: private:

10
src/common/webrequest_curl.cpp
View File

@@ -278,10 +278,7 @@ void wxWebRequestCURL::HandleCompletion()
{ {
m_authChallenge.reset(new wxWebAuthChallengeCURL( m_authChallenge.reset(new wxWebAuthChallengeCURL(
(status == 407) ? wxWebAuthChallenge::Source_Proxy : wxWebAuthChallenge::Source_Server, *this)); (status == 407) ? wxWebAuthChallenge::Source_Proxy : wxWebAuthChallenge::Source_Server, *this));
if ( m_authChallenge->Init() ) SetState(wxWebRequest::State_Unauthorized, m_response->GetStatusText());
SetState(wxWebRequest::State_Unauthorized, m_response->GetStatusText());
else
SetState(wxWebRequest::State_Failed);
} }
else if ( CheckServerStatus() ) else if ( CheckServerStatus() )
SetState(wxWebRequest::State_Completed); SetState(wxWebRequest::State_Completed);
@@ -337,11 +334,6 @@ wxWebAuthChallengeCURL::wxWebAuthChallengeCURL(wxWebAuthChallenge::Source source
{ {
} }
bool wxWebAuthChallengeCURL::Init()
{
return true;
}
void wxWebAuthChallengeCURL::SetCredentials(const wxWebCredentials& cred) void wxWebAuthChallengeCURL::SetCredentials(const wxWebCredentials& cred)
{ {
const wxSecretString authStr = const wxSecretString authStr =