Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clear old selection when wxListBox becomes empty.

Browse Source 
When UpdateOldSelections() is called from wxListBox::DoClear(), it must clear
the old selections array even for single selection list boxes, but it didn't
do this under non-MSW platforms.

Specifically check for the case of an empty listbox now and just forget the
old selections then. This fixes the problem of keeping stale old selections
and is also more efficient as we avoid the unnecessary GetSelections() call.

Really closes #14359.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@71637 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2012-06-01 22:34:17 +00:00
parent 125afca0c0
commit 0c9dd3b69b
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/common/lboxcmn.cpp
View File

@@ -167,6 +167,14 @@ void wxListBoxBase::DeselectAll(int itemToLeaveSelected)
void wxListBoxBase::UpdateOldSelections() void wxListBoxBase::UpdateOldSelections()
{ {
// When the control becomes empty, any previously remembered selections are
// invalid anyhow, so just forget them.
if ( IsEmpty() )
{
m_oldSelections.clear();
return;
}
// We need to remember the selection even in single-selection case on // We need to remember the selection even in single-selection case on
// Windows, so that we don't send an event when the user clicks on an // Windows, so that we don't send an event when the user clicks on an
// already selected item. // already selected item.