Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't unnecessarily use heap-allocated objects in a test

Browse Source 
Just use local stack variables instead.
This commit is contained in:
Vadim Zeitlin
2017-11-05 17:30:46 +01:00
parent 10b80a16f0
commit 0858cd52a7
1 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/streams/textstreamtest.cpp
View File

@@ -109,23 +109,20 @@ void TextStreamTestCase::Endline()
{ {
TempFile f("test.txt"); TempFile f("test.txt");
wxFileOutputStream* pOutFile = new wxFileOutputStream(f.GetName()); {
wxTextOutputStream* pOutText = new wxTextOutputStream(*pOutFile); wxFileOutputStream pOutFile(f.GetName());
*pOutText << wxT("Test text") << endl wxTextOutputStream pOutText(pOutFile);
<< wxT("More Testing Text (There should be newline before this)"); pOutText << wxT("Test text") << endl
<< wxT("More Testing Text (There should be newline before this)");
}
delete pOutText; wxFileInputStream pInFile(f.GetName());
delete pOutFile;
wxFileInputStream* pInFile = new wxFileInputStream(f.GetName());
char szIn[9 + NEWLINELEN]; char szIn[9 + NEWLINELEN];
pInFile->Read(szIn, 9 + NEWLINELEN); pInFile.Read(szIn, 9 + NEWLINELEN);
CPPUNIT_ASSERT( memcmp(&szIn[9], NEWLINE, NEWLINELEN) == 0 ); CPPUNIT_ASSERT( memcmp(&szIn[9], NEWLINE, NEWLINELEN) == 0 );
delete pInFile;
} }
void TextStreamTestCase::MiscTests() void TextStreamTestCase::MiscTests()