Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve responsiveness of a wxGrid having plenty of attributes

Browse Source 
Speed up grid attribute lookups by using a hash map instead of array.

Closes #12764.
This commit is contained in:
Dimitri Schoolwerth
2021-02-09 23:50:28 +01:00
parent 84c989626d
commit 061191e659
2 changed files with 92 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
include/wx/generic/private/grid.h
View File

@@ -71,8 +71,9 @@ struct wxGridCellWithAttr
wxGridCellAttr *attr;
};
WX_DECLARE_OBJARRAY_WITH_DECL(wxGridCellWithAttr, wxGridCellWithAttrArray,
class WXDLLIMPEXP_ADV);
WX_DECLARE_HASH_MAP_WITH_DECL(wxLongLong_t, wxGridCellWithAttr*,
wxIntegerHash, wxIntegerEqual,
wxGridCoordsToAttrMap, class WXDLLIMPEXP_CORE);
// ----------------------------------------------------------------------------
@@ -468,16 +469,18 @@ private:
class WXDLLIMPEXP_ADV wxGridCellAttrData
{
public:
~wxGridCellAttrData();
void SetAttr(wxGridCellAttr *attr, int row, int col);
wxGridCellAttr *GetAttr(int row, int col) const;
void UpdateAttrRows( size_t pos, int numRows );
void UpdateAttrCols( size_t pos, int numCols );
private:
// searches for the attr for given cell, returns wxNOT_FOUND if not found
int FindIndex(int row, int col) const;
// Tries to search for the attr for given cell.
wxGridCoordsToAttrMap::iterator FindIndex(int row, int col) const;
wxGridCellWithAttrArray m_attrs;
mutable wxGridCoordsToAttrMap m_attrs;
};
// this class stores attributes set for rows or columns