From 04d82e24cd3cbd63902453a696d8f727002cfcb3 Mon Sep 17 00:00:00 2001
From: Maarten Bent <MaartenBent@users.noreply.github.com>
Date: Sun, 26 Apr 2020 19:33:20 +0200
Subject: [PATCH] CMake: enable -Wall for builds using clang or gcc

---
 build/cmake/functions.cmake | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/build/cmake/functions.cmake b/build/cmake/functions.cmake
index 26268d4db0..03004a9181 100644
--- a/build/cmake/functions.cmake
+++ b/build/cmake/functions.cmake
@@ -98,8 +98,15 @@ function(wx_set_common_target_properties target_name)
             set(MSVC_WARNING_LEVEL "/W4")
         endif()
         target_compile_options(${target_name} PRIVATE ${MSVC_WARNING_LEVEL})
-    else()
-        # TODO: add warning flags for other compilers
+    elseif("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" AND NOT wxCOMMON_TARGET_PROPS_DEFAULT_WARNINGS)
+        target_compile_options(${target_name} PRIVATE
+            -Wall
+            )
+    elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" AND NOT wxCOMMON_TARGET_PROPS_DEFAULT_WARNINGS)
+        target_compile_options(${target_name} PRIVATE
+            -Wall
+            -Wno-ignored-attributes
+            )
     endif()
 
     if(CMAKE_USE_PTHREADS_INIT)