Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix sending show events when hiding frozen windows in wxMSW

Browse Source 
Send these events ourselves because MSW itself doesn't generate them for
frozen windows. This makes wxMSW more consistent with the other ports.

Add unit tests to verify that the behaviour is really as expected for
both normal and frozen windows, at least under MSW -- under GTK these
events are not sent at all for the notebook pages.

Closes #19216.
This commit is contained in:
Dummy
2022-01-08 18:48:52 +00:00
committed by Vadim Zeitlin
parent ef779835b4
commit 006fd1a511
3 changed files with 177 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
tests/controls/windowtest.cpp
View File

@@ -26,6 +26,7 @@
#include "wx/scopedptr.h"
#include "wx/stopwatch.h"
#include "wx/tooltip.h"
#include "wx/wupdlock.h"
class WindowTestCase
{
@@ -53,25 +54,43 @@ protected:
wxDECLARE_NO_COPY_CLASS(WindowTestCase);
};
TEST_CASE_METHOD(WindowTestCase, "Window::ShowHideEvent", "[window]")
{
#if defined(__WXMSW__)
EventCounter show(m_window, wxEVT_SHOW);
CHECK(m_window->IsShown());
static void DoTestShowHideEvent(wxWindow* window)
{
EventCounter show(window, wxEVT_SHOW);
m_window->Show(false);
CHECK(window->IsShown());
CHECK(!m_window->IsShown());
window->Show(false);
m_window->Show();
CHECK(!window->IsShown());
CHECK(m_window->IsShown());
window->Show();
CHECK(window->IsShown());
CHECK( show.GetCount() == 2 );
#endif // __WXMSW__
}
TEST_CASE_METHOD(WindowTestCase, "Window::ShowHideEvent", "[window]")
{
SECTION("Normal window")
{
DoTestShowHideEvent(m_window);
}
SECTION("Frozen window")
{
wxWindowUpdateLocker freeze(m_window->GetParent() );
REQUIRE( m_window->IsFrozen() );
DoTestShowHideEvent(m_window);
}
}
#endif // __WXMSW__
TEST_CASE_METHOD(WindowTestCase, "Window::KeyEvent", "[window]")
{
#if wxUSE_UIACTIONSIMULATOR