remove obsolete color cube and image to bitmap code

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@39793 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

include/wx/gtk/app.h

@@ -54,8 +54,6 @@ public:
 
     gint            m_idleTag;
     void RemoveIdleTag();
-    
-    unsigned char  *m_colorCube;
 
     // Used by the the wxGLApp and wxGLCanvas class for GL-based X visual
     // selection.

src/gtk/app.cpp

@@ -431,8 +431,6 @@ wxApp::wxApp()
     g_main_context_set_poll_func( NULL, wxapp_poll_func );
 #endif
 
-    m_colorCube = (unsigned char*) NULL;
-
     // this is NULL for a "regular" wxApp, but is set (and freed) by a wxGLApp
     m_glVisualInfo = (void *) NULL;
     m_glFBCInfo = (void *) NULL;
@@ -442,9 +440,6 @@ wxApp::~wxApp()
 {
     if (m_idleTag)
         g_source_remove( m_idleTag );
-
-    if (m_colorCube)
-        free(m_colorCube);
 }
 
 bool wxApp::OnInitGui()
@@ -452,8 +447,6 @@ bool wxApp::OnInitGui()
     if ( !wxAppBase::OnInitGui() )
         return false;
 
-    GdkVisual *visual = gdk_visual_get_system();
-
     // if this is a wxGLApp (derived from wxApp), and we've already
     // chosen a specific visual, then derive the GdkVisual from that
     if (m_glVisualInfo != NULL)
@@ -463,8 +456,6 @@ bool wxApp::OnInitGui()
 
         GdkColormap *colormap = gdk_colormap_new( vis, FALSE );
         gtk_widget_set_default_colormap( colormap );
-
-        visual = vis;
     }
 
     // On some machines, the default visual is just 256 colours, so
@@ -478,59 +469,6 @@ bool wxApp::OnInitGui()
 
         GdkColormap *colormap = gdk_colormap_new( vis, FALSE );
         gtk_widget_set_default_colormap( colormap );
-
-        visual = vis;
-    }
-
-    // Nothing to do for 15, 16, 24, 32 bit displays
-    if (visual->depth > 8) return true;
-
-    // initialize color cube for 8-bit color reduction dithering
-
-    GdkColormap *cmap = gtk_widget_get_default_colormap();
-
-    m_colorCube = (unsigned char*)malloc(32 * 32 * 32);
-
-    for (int r = 0; r < 32; r++)
-    {
-        for (int g = 0; g < 32; g++)
-        {
-            for (int b = 0; b < 32; b++)
-            {
-                int rr = (r << 3) | (r >> 2);
-                int gg = (g << 3) | (g >> 2);
-                int bb = (b << 3) | (b >> 2);
-
-                int index = -1;
-
-                GdkColor *colors = cmap->colors;
-                if (colors)
-                {
-                    int max = 3 * 65536;
-
-                    for (int i = 0; i < cmap->size; i++)
-                    {
-                        int rdiff = ((rr << 8) - colors[i].red);
-                        int gdiff = ((gg << 8) - colors[i].green);
-                        int bdiff = ((bb << 8) - colors[i].blue);
-                        int sum = ABS (rdiff) + ABS (gdiff) + ABS (bdiff);
-                        if (sum < max)
-                        {
-                            index = i; max = sum;
-                        }
-                    }
-                }
-                else
-                {
-                    // assume 8-bit true or static colors. this really exists
-                    GdkVisual* vis = gdk_colormap_get_visual( cmap );
-                    index = (r >> (5 - vis->red_prec)) << vis->red_shift;
-                    index |= (g >> (5 - vis->green_prec)) << vis->green_shift;
-                    index |= (b >> (5 - vis->blue_prec)) << vis->blue_shift;
-                }
-                m_colorCube[ (r*1024) + (g*32) + b ] = index;
-            }
-        }
     }
 
     return true;

src/gtk/bitmap.cpp

@@ -700,77 +700,33 @@ bool wxBitmap::CreateFromImageAsPixmap(const wxImage& img)
 
     SetDepth( bpp );
 
-    if ((bpp == 16) && (visual->red_mask != 0xf800))
+    GdkGC *gc = gdk_gc_new( GetPixmap() );
-        bpp = 15;
-    else if (bpp < 8)
-        bpp = 8;
 
-    // We handle 8-bit bitmaps ourselves using the colour cube, 12-bit
+    gdk_draw_rgb_image( GetPixmap(),
-    // visuals are not supported by GDK so we do these ourselves, too.
+                        gc,
-    // 15-bit and 16-bit should actually work and 24-bit certainly does.
+                        0, 0,
-#ifdef __sgi
+                        width, height,
-    if (!image.HasMask() && (bpp > 16))
+                        GDK_RGB_DITHER_NONE,
-#else
+                        image.GetData(),
-    if (!image.HasMask() && (bpp > 12))
+                        width*3 );
-#endif
-    {
-        static bool s_hasInitialized = false;
 
-        if (!s_hasInitialized)
+    g_object_unref (gc);
-        {
-            gdk_rgb_init();
-            s_hasInitialized = true;
-        }
-
-        GdkGC *gc = gdk_gc_new( GetPixmap() );
-
-        gdk_draw_rgb_image( GetPixmap(),
-                            gc,
-                            0, 0,
-                            width, height,
-                            GDK_RGB_DITHER_NONE,
-                            image.GetData(),
-                            width*3 );
-
-        g_object_unref (gc);
-        return true;
-    }
-
-    // Create picture image
-
-    GdkImage *data_image =
-        gdk_image_new( GDK_IMAGE_FASTEST, visual, width, height );
 
     // Create mask image
 
     GdkImage *mask_image = (GdkImage*) NULL;
 
-    if (image.HasMask())
+    if (!image.HasMask())
-    {
+        return true;
-        unsigned char *mask_data = (unsigned char*)malloc( ((width >> 3)+8) * height );
 
-        mask_image =  gdk_image_new_bitmap( visual, mask_data, width, height );
+    unsigned char *mask_data = (unsigned char*)malloc( ((width >> 3)+8) * height );
 
-        wxMask *mask = new wxMask();
+    mask_image =  gdk_image_new_bitmap( visual, mask_data, width, height );
-        mask->m_bitmap = gdk_pixmap_new( wxGetRootWindow()->window, width, height, 1 );
 
-        SetMask( mask );
+    wxMask *mask = new wxMask();
-    }
+    mask->m_bitmap = gdk_pixmap_new( wxGetRootWindow()->window, width, height, 1 );
 
-    // Render
+    SetMask( mask );
-
-    enum byte_order { RGB, RBG, BRG, BGR, GRB, GBR };
-    byte_order b_o = RGB;
-
-    if (bpp > 8)
-    {
-        if ((visual->red_mask > visual->green_mask) && (visual->green_mask > visual->blue_mask))      b_o = RGB;
-        else if ((visual->red_mask > visual->blue_mask) && (visual->blue_mask > visual->green_mask))  b_o = RBG;
-        else if ((visual->blue_mask > visual->red_mask) && (visual->red_mask > visual->green_mask))   b_o = BRG;
-        else if ((visual->blue_mask > visual->green_mask) && (visual->green_mask > visual->red_mask)) b_o = BGR;
-        else if ((visual->green_mask > visual->red_mask) && (visual->red_mask > visual->blue_mask))   b_o = GRB;
-        else if ((visual->green_mask > visual->blue_mask) && (visual->blue_mask > visual->red_mask))  b_o = GBR;
-    }
 
     int r_mask = image.GetMaskRed();
     int g_mask = image.GetMaskGreen();
@@ -790,131 +746,21 @@ bool wxBitmap::CreateFromImageAsPixmap(const wxImage& img)
             int b = data[index];
             index++;
 
-            if (image.HasMask())
+            if ((r == r_mask) && (b == b_mask) && (g == g_mask))
-            {
+                gdk_image_put_pixel( mask_image, x, y, 1 );
-                if ((r == r_mask) && (b == b_mask) && (g == g_mask))
+            else
-                    gdk_image_put_pixel( mask_image, x, y, 1 );
+                gdk_image_put_pixel( mask_image, x, y, 0 );
-                else
-                    gdk_image_put_pixel( mask_image, x, y, 0 );
-            }
-
-            switch (bpp)
-            {
-                case 8:
-                {
-                    int pixel = -1;
-                    if (wxTheApp->m_colorCube)
-                    {
-                        pixel = wxTheApp->m_colorCube[ ((r & 0xf8) << 7) + ((g & 0xf8) << 2) + ((b & 0xf8) >> 3) ];
-                    }
-                    else
-                    {
-                        GdkColormap *cmap = gtk_widget_get_default_colormap();
-                        GdkColor *colors = cmap->colors;
-                        int max = 3 * (65536);
-
-                        for (int i = 0; i < cmap->size; i++)
-                        {
-                            int rdiff = (r << 8) - colors[i].red;
-                            int gdiff = (g << 8) - colors[i].green;
-                            int bdiff = (b << 8) - colors[i].blue;
-                            int sum = ABS (rdiff) + ABS (gdiff) + ABS (bdiff);
-                            if (sum < max) { pixel = i; max = sum; }
-                        }
-                    }
-
-                    gdk_image_put_pixel( data_image, x, y, pixel );
-
-                    break;
-                }
-                case 12:  // SGI only
-                {
-                    guint32 pixel = 0;
-                    switch (b_o)
-                    {
-                        case RGB: pixel = ((r & 0xf0) << 4) | (g & 0xf0) | ((b & 0xf0) >> 4); break;
-                        case RBG: pixel = ((r & 0xf0) << 4) | (b & 0xf0) | ((g & 0xf0) >> 4); break;
-                        case GRB: pixel = ((g & 0xf0) << 4) | (r & 0xf0) | ((b & 0xf0) >> 4); break;
-                        case GBR: pixel = ((g & 0xf0) << 4) | (b & 0xf0) | ((r & 0xf0) >> 4); break;
-                        case BRG: pixel = ((b & 0xf0) << 4) | (r & 0xf0) | ((g & 0xf0) >> 4); break;
-                        case BGR: pixel = ((b & 0xf0) << 4) | (g & 0xf0) | ((r & 0xf0) >> 4); break;
-                    }
-                    gdk_image_put_pixel( data_image, x, y, pixel );
-                    break;
-                }
-                case 15:
-                {
-                    guint32 pixel = 0;
-                    switch (b_o)
-                    {
-                        case RGB: pixel = ((r & 0xf8) << 7) | ((g & 0xf8) << 2) | ((b & 0xf8) >> 3); break;
-                        case RBG: pixel = ((r & 0xf8) << 7) | ((b & 0xf8) << 2) | ((g & 0xf8) >> 3); break;
-                        case GRB: pixel = ((g & 0xf8) << 7) | ((r & 0xf8) << 2) | ((b & 0xf8) >> 3); break;
-                        case GBR: pixel = ((g & 0xf8) << 7) | ((b & 0xf8) << 2) | ((r & 0xf8) >> 3); break;
-                        case BRG: pixel = ((b & 0xf8) << 7) | ((r & 0xf8) << 2) | ((g & 0xf8) >> 3); break;
-                        case BGR: pixel = ((b & 0xf8) << 7) | ((g & 0xf8) << 2) | ((r & 0xf8) >> 3); break;
-                    }
-                    gdk_image_put_pixel( data_image, x, y, pixel );
-                    break;
-                }
-                case 16:
-                {
-                    // I actually don't know if for 16-bit displays, it is alway the green
-                    // component or the second component which has 6 bits.
-                    guint32 pixel = 0;
-                    switch (b_o)
-                    {
-                        case RGB: pixel = ((r & 0xf8) << 8) | ((g & 0xfc) << 3) | ((b & 0xf8) >> 3); break;
-                        case RBG: pixel = ((r & 0xf8) << 8) | ((b & 0xfc) << 3) | ((g & 0xf8) >> 3); break;
-                        case GRB: pixel = ((g & 0xf8) << 8) | ((r & 0xfc) << 3) | ((b & 0xf8) >> 3); break;
-                        case GBR: pixel = ((g & 0xf8) << 8) | ((b & 0xfc) << 3) | ((r & 0xf8) >> 3); break;
-                        case BRG: pixel = ((b & 0xf8) << 8) | ((r & 0xfc) << 3) | ((g & 0xf8) >> 3); break;
-                        case BGR: pixel = ((b & 0xf8) << 8) | ((g & 0xfc) << 3) | ((r & 0xf8) >> 3); break;
-                    }
-                    gdk_image_put_pixel( data_image, x, y, pixel );
-                    break;
-                }
-                case 32:
-                case 24:
-                {
-                    guint32 pixel = 0;
-                    switch (b_o)
-                    {
-                        case RGB: pixel = (r << 16) | (g << 8) | b; break;
-                        case RBG: pixel = (r << 16) | (b << 8) | g; break;
-                        case BRG: pixel = (b << 16) | (r << 8) | g; break;
-                        case BGR: pixel = (b << 16) | (g << 8) | r; break;
-                        case GRB: pixel = (g << 16) | (r << 8) | b; break;
-                        case GBR: pixel = (g << 16) | (b << 8) | r; break;
-                    }
-                    gdk_image_put_pixel( data_image, x, y, pixel );
-                    break;
-                }
-                default: break;
-            }
         } // for
     }  // for
 
-    // Blit picture
-
-    GdkGC *data_gc = gdk_gc_new( GetPixmap() );
-
-    gdk_draw_image( GetPixmap(), data_gc, data_image, 0, 0, 0, 0, width, height );
-
-    g_object_unref (data_image);
-    g_object_unref (data_gc);
-
     // Blit mask
 
-    if (image.HasMask())
+    GdkGC *mask_gc = gdk_gc_new( GetMask()->GetBitmap() );
-    {
-        GdkGC *mask_gc = gdk_gc_new( GetMask()->GetBitmap() );
 
-        gdk_draw_image( GetMask()->GetBitmap(), mask_gc, mask_image, 0, 0, 0, 0, width, height );
+    gdk_draw_image( GetMask()->GetBitmap(), mask_gc, mask_image, 0, 0, 0, 0, width, height );
 
-        g_object_unref (mask_image);
+    g_object_unref (mask_image);
-        g_object_unref (mask_gc);
+    g_object_unref (mask_gc);
-    }
 
     return true;
 }