Common: Require explicit handle validation
Some checks failed
CodeQL / Analyze (cpp) (push) Has been cancelled
Doxygen Action / build (push) Has been cancelled

Using operator bool() hid ambiguity when handle was polymorfic with
bool. Using operator!() reqired !! to test for validity which results in
awkward code.

Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman 2025-07-08 11:15:54 +02:00
parent 9e992db24e
commit 75c5630dbc
2 changed files with 2 additions and 2 deletions

View File

@ -125,7 +125,7 @@ namespace winstd
if (this != std::addressof(h)) {
if (m_h != invalid)
free_internal();
if (h)
if (h.valid())
duplicate_internal(h);
else
m_h = invalid;

View File

@ -1665,7 +1665,7 @@ namespace winstd
};
sa = SafeArrayCreate(VT_VARIANT, _countof(dim), dim);
}
if (!sa)
if (!sa.valid())
throw std::bad_alloc();
assert(SafeArrayGetElemsize(sa) == sizeof(VARIANT));