Amebis/WinStd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Common: Require explicit handle validation
Some checks failed
CodeQL / Analyze (cpp) (push) Has been cancelled
Details
Doxygen Action / build (push) Has been cancelled
Details

Browse Source 
Using operator bool() hid ambiguity when handle was polymorfic with
bool. Using operator!() reqired !! to test for validity which results in
awkward code.

Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman 2025-07-08 11:15:54 +02:00
parent 9e992db24e
commit 75c5630dbc
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/WinStd/BCrypt.h
View File

@ -125,7 +125,7 @@ namespace winstd
if (this != std::addressof(h)) { if (this != std::addressof(h)) {
if (m_h != invalid) if (m_h != invalid)
free_internal(); free_internal();
if (h) if (h.valid())
duplicate_internal(h); duplicate_internal(h);
else else
m_h = invalid; m_h = invalid;

2
include/WinStd/COM.h
View File

@ -1665,7 +1665,7 @@ namespace winstd
}; };
sa = SafeArrayCreate(VT_VARIANT, _countof(dim), dim); sa = SafeArrayCreate(VT_VARIANT, _countof(dim), dim);
} }
if (!sa) if (!sa.valid())
throw std::bad_alloc(); throw std::bad_alloc();
assert(SafeArrayGetElemsize(sa) == sizeof(VARIANT)); assert(SafeArrayGetElemsize(sa) == sizeof(VARIANT));