Amebis/WinStd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clear warning suppression

Browse Source 
Code analysis got quite good and we'd better keep warnings on our radar.

Either:
1. Research and resolve the reason for the warning.
2. Remove silencing and let code analysis complain.
3. Comment why some warning silencing is there.

Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman 2025-04-01 15:18:43 +02:00
parent 6607f20873
commit 2e03659948
5 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/WinStd/COM.h
View File

@ -1718,10 +1718,8 @@ namespace winstd
// Fill in BITMAPFILEHEADER. // Fill in BITMAPFILEHEADER.
memset(header, 0, sizeof(*header)); memset(header, 0, sizeof(*header));
#pragma warning(push) #pragma warning(suppress: 6276) // "BM" is not an UTF16 char.
#pragma warning(disable: 6276) // "BM" is not an UTF16 char.
header->bfType = *reinterpret_cast<WORD*>("BM"); header->bfType = *reinterpret_cast<WORD*>("BM");
#pragma warning(pop)
header->bfSize = static_cast<DWORD>(sizeof(*header) + sizeof(bmh) + pallete_size + bmh.biSizeImage); header->bfSize = static_cast<DWORD>(sizeof(*header) + sizeof(bmh) + pallete_size + bmh.biSizeImage);
header->bfOffBits = static_cast<DWORD>(sizeof(*header) + sizeof(bmh) + pallete_size); header->bfOffBits = static_cast<DWORD>(sizeof(*header) + sizeof(bmh) + pallete_size);
@ -1749,7 +1747,7 @@ namespace winstd
/// \param[in] locale Locale for the invoke call /// \param[in] locale Locale for the invoke call
/// ///
template <class T> template <class T>
void IDispatchInvoke(_In_ T* cp, _In_ DISPID id, _In_opt_ DISPPARAMS* param, _In_ LCID locale = LOCALE_USER_DEFAULT) void IDispatchInvoke(_In_ T* cp, _In_ DISPID id, _In_ DISPPARAMS* param, _In_ LCID locale = LOCALE_USER_DEFAULT)
{ {
assert(cp); assert(cp);
com_obj<IEnumConnections> e; com_obj<IEnumConnections> e;

2
include/WinStd/Common.h
View File

@ -1207,7 +1207,7 @@ namespace winstd
/// ///
/// \param[inout] h A rvalue reference of another object /// \param[inout] h A rvalue reference of another object
/// ///
#pragma warning(disable: 26432) // Move constructor is also present, but not detected by code analysis somehow. #pragma warning(suppress: 26432) // Move constructor is also present, but not detected by code analysis somehow.
dplhandle<handle_type, INVAL>& operator=(_Inout_ dplhandle<handle_type, INVAL> &&h) noexcept dplhandle<handle_type, INVAL>& operator=(_Inout_ dplhandle<handle_type, INVAL> &&h) noexcept
{ {
handle<handle_type, INVAL>::operator=(std::move(h)); handle<handle_type, INVAL>::operator=(std::move(h));

5
include/WinStd/EAP.h
View File

@ -74,7 +74,7 @@ namespace winstd
/// ///
/// \sa [Extensible Authentication Protocol (EAP) Registry (Chapter: Method Types)](https://www.iana.org/assignments/eap-numbers/eap-numbers.xhtml#eap-numbers-4) /// \sa [Extensible Authentication Protocol (EAP) Registry (Chapter: Method Types)](https://www.iana.org/assignments/eap-numbers/eap-numbers.xhtml#eap-numbers-4)
/// ///
#pragma warning(suppress: 4480) #pragma warning(suppress: 4480) // Prefering enums over #define for constants
enum class eap_type_t : unsigned char { enum class eap_type_t : unsigned char {
undefined = 0, ///< Undefined EAP type undefined = 0, ///< Undefined EAP type
identity = 1, ///< Identity identity = 1, ///< Identity
@ -319,8 +319,6 @@ namespace winstd
nKeySize + // Key nKeySize + // Key
nPaddingLength; // Padding nPaddingLength; // Padding
#pragma warning(push)
#pragma warning(disable: 6386)
LPBYTE p = new BYTE[dwLengthNew]; LPBYTE p = new BYTE[dwLengthNew];
p[0] = 0x00; // Vendor-Id (0x137 = 311 = Microsoft) p[0] = 0x00; // Vendor-Id (0x137 = 311 = Microsoft)
p[1] = 0x00; // --| p[1] = 0x00; // --|
@ -331,7 +329,6 @@ namespace winstd
p[6] = 0x00; // Salt p[6] = 0x00; // Salt
p[7] = 0x00; // --^ p[7] = 0x00; // --^
p[8] = nKeySize; // Key-Length p[8] = nKeySize; // Key-Length
#pragma warning(pop)
memcpy(p + 9, pbKey, nKeySize); // Key memcpy(p + 9, pbKey, nKeySize); // Key
memset(p + 9 + nKeySize, 0, nPaddingLength); // Padding memset(p + 9 + nKeySize, 0, nPaddingLength); // Padding

6
include/WinStd/ETW.h
View File

@ -600,10 +600,7 @@ namespace winstd
} }
va_end(arg); va_end(arg);
#pragma warning(push)
#pragma warning(disable: 28020)
return EventWrite(m_h, EventDescriptor, param_count, params.data()); return EventWrite(m_h, EventDescriptor, param_count, params.data());
#pragma warning(pop)
} }
/// ///
@ -644,10 +641,7 @@ namespace winstd
params.push_back(p); params.push_back(p);
} }
#pragma warning(push)
#pragma warning(disable: 28020)
return EventWrite(m_h, EventDescriptor, param_count, params.data()); return EventWrite(m_h, EventDescriptor, param_count, params.data());
#pragma warning(pop)
} }
/// ///

5
include/WinStd/Win.h
View File

@ -1913,16 +1913,11 @@ namespace winstd
/// ///
~process_information() ~process_information()
{ {
#pragma warning(push)
#pragma warning(disable: 6001) // Using uninitialized memory '*this'. << ???
if (hProcess != INVALID_HANDLE_VALUE) if (hProcess != INVALID_HANDLE_VALUE)
CloseHandle(hProcess); CloseHandle(hProcess);
if (hThread != INVALID_HANDLE_VALUE) if (hThread != INVALID_HANDLE_VALUE)
CloseHandle(hThread); CloseHandle(hThread);
#pragma warning(pop)
} }
}; };