Fix StubPath for products in ACTIVESETUPFAULTYPRODUCTS

The products using Active Setup prior to
18cd389029502ec73da4b62ecdc1792ebdb805f8 upgrade are prone to uninstall
failure because of the missing StubPath value in the registry.

Author the Upgrade table of the package to have those products listed in
a property called `ACTIVESETUPFAULTYPRODUCTS` to inject StubPath in the
registry before RemoveExistingProducts.

Signed-off-by: Simon Rozman <simon@rozman.si>

Core/Binary/EvaluateFixActiveSetup.js

@@ -0,0 +1,26 @@
+/*
+ *  MSIBuild — MSI packaging
+ *
+ *  Copyright (C) 2018-2020 Amebis <info@amebis.si>
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2
+ *  as published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License along
+ *  with this program; if not, write to the Free Software Foundation, Inc.,
+ *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+
+/**
+ * Prepares instructions for FixActiveSetup deferred action.
+ */
+
+// Save the data for the deferred action.
+Session.Property("FixActiveSetup") = Session.Property("ACTIVESETUPFAULTYPRODUCTS")

Core/Binary/FixActiveSetup.js

@@ -0,0 +1,36 @@
+/*
+ *  MSIBuild — MSI packaging
+ *
+ *  Copyright (C) 2018-2020 Amebis <info@amebis.si>
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2
+ *  as published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License along
+ *  with this program; if not, write to the Free Software Foundation, Inc.,
+ *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+ 
+/**
+ * Fixes Active Setup component to allow graceful uninstall
+ *
+ * This is a deffered execution action. CustomActionData property should be a semicolon delimited
+ * list of product IDs that require this fix to be uninstalled successfuly.
+ */
+
+var data = Session.Property("CustomActionData").split(";");
+if (data) {
+	var wsh = new ActiveXObject("WScript.Shell");
+
+	for (var i in data) {
+		var regPath = "HKLM\\Software\\Microsoft\\Active Setup\\Installed Components\\" + data[i] + "\\";
+		wsh.RegWrite(regPath + "StubPath", "\"%SystemRoot%\\system32\\msiexec.exe\" /fu \"" + data[i] + "\" /qn", "REG_EXPAND_SZ");
+	}
+}