From e7e1a6735d8de3764c03452c2ee200a9a45b1c81 Mon Sep 17 00:00:00 2001 From: Simon Rozman Date: Mon, 24 Oct 2016 14:55:31 +0200 Subject: [PATCH] pEapOutput Prefast specifier for process_request_packet() methods changed --- lib/EAPBase/include/Method.h | 2 +- lib/EAPBase/include/Module.h | 2 +- lib/EAPMsg/include/Method.h | 2 +- lib/EAPMsg/src/Method.cpp | 2 +- lib/MSCHAPv2/include/Method.h | 2 +- lib/MSCHAPv2/src/Method.cpp | 2 +- lib/PAP/include/Method.h | 2 +- lib/PAP/src/Method.cpp | 2 +- lib/TLS/include/Method.h | 2 +- lib/TLS/src/Method.cpp | 2 +- lib/TTLS/include/Method.h | 2 +- lib/TTLS/include/Module.h | 2 +- lib/TTLS/src/Method.cpp | 2 +- lib/TTLS/src/Module.cpp | 2 +- 14 files changed, 14 insertions(+), 14 deletions(-) diff --git a/lib/EAPBase/include/Method.h b/lib/EAPBase/include/Method.h index d73a98b..ed28c35 100644 --- a/lib/EAPBase/include/Method.h +++ b/lib/EAPBase/include/Method.h @@ -108,7 +108,7 @@ namespace eap virtual void process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput) = 0; + _Out_ EapPeerMethodOutput *pEapOutput) = 0; /// /// Obtains a response packet from the EAP method. diff --git a/lib/EAPBase/include/Module.h b/lib/EAPBase/include/Module.h index a20132d..7bc529e 100644 --- a/lib/EAPBase/include/Module.h +++ b/lib/EAPBase/include/Module.h @@ -717,7 +717,7 @@ namespace eap _In_ EAP_SESSION_HANDLE hSession, _In_bytecount_(dwReceivedPacketSize) const EapPacket *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput) = 0; + _Out_ EapPeerMethodOutput *pEapOutput) = 0; /// /// Obtains a response packet from the EAP method. diff --git a/lib/EAPMsg/include/Method.h b/lib/EAPMsg/include/Method.h index 9a3c9ee..61ccff6 100644 --- a/lib/EAPMsg/include/Method.h +++ b/lib/EAPMsg/include/Method.h @@ -89,7 +89,7 @@ namespace eap virtual void process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput); + _Out_ EapPeerMethodOutput *pEapOutput); /// @} diff --git a/lib/EAPMsg/src/Method.cpp b/lib/EAPMsg/src/Method.cpp index 72c8b3b..0221dc6 100644 --- a/lib/EAPMsg/src/Method.cpp +++ b/lib/EAPMsg/src/Method.cpp @@ -72,7 +72,7 @@ void eap::method_eapmsg::begin_session( void eap::method_eapmsg::process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput) + _Out_ EapPeerMethodOutput *pEapOutput) { UNREFERENCED_PARAMETER(pReceivedPacket); assert(pReceivedPacket || dwReceivedPacketSize == 0); diff --git a/lib/MSCHAPv2/include/Method.h b/lib/MSCHAPv2/include/Method.h index 8f32553..239daf4 100644 --- a/lib/MSCHAPv2/include/Method.h +++ b/lib/MSCHAPv2/include/Method.h @@ -90,7 +90,7 @@ namespace eap virtual void process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput); + _Out_ EapPeerMethodOutput *pEapOutput); /// @} diff --git a/lib/MSCHAPv2/src/Method.cpp b/lib/MSCHAPv2/src/Method.cpp index 7bb229e..15005f7 100644 --- a/lib/MSCHAPv2/src/Method.cpp +++ b/lib/MSCHAPv2/src/Method.cpp @@ -90,7 +90,7 @@ void eap::method_mschapv2::begin_session( void eap::method_mschapv2::process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput) + _Out_ EapPeerMethodOutput *pEapOutput) { assert(pReceivedPacket || dwReceivedPacketSize == 0); assert(pEapOutput); diff --git a/lib/PAP/include/Method.h b/lib/PAP/include/Method.h index 8a9bf11..0f47c1c 100644 --- a/lib/PAP/include/Method.h +++ b/lib/PAP/include/Method.h @@ -88,7 +88,7 @@ namespace eap virtual void process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput); + _Out_ EapPeerMethodOutput *pEapOutput); /// @} diff --git a/lib/PAP/src/Method.cpp b/lib/PAP/src/Method.cpp index 8d197d6..1a602f7 100644 --- a/lib/PAP/src/Method.cpp +++ b/lib/PAP/src/Method.cpp @@ -72,7 +72,7 @@ void eap::method_pap::begin_session( void eap::method_pap::process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput) + _Out_ EapPeerMethodOutput *pEapOutput) { UNREFERENCED_PARAMETER(pReceivedPacket); assert(pReceivedPacket || dwReceivedPacketSize == 0); diff --git a/lib/TLS/include/Method.h b/lib/TLS/include/Method.h index 72627f6..d473e9c 100644 --- a/lib/TLS/include/Method.h +++ b/lib/TLS/include/Method.h @@ -110,7 +110,7 @@ namespace eap virtual void process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput); + _Out_ EapPeerMethodOutput *pEapOutput); /// /// Obtains a response packet from the EAP method. diff --git a/lib/TLS/src/Method.cpp b/lib/TLS/src/Method.cpp index 637304a..683da01 100644 --- a/lib/TLS/src/Method.cpp +++ b/lib/TLS/src/Method.cpp @@ -249,7 +249,7 @@ void eap::method_tls::begin_session( void eap::method_tls::process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput) + _Out_ EapPeerMethodOutput *pEapOutput) { assert(pReceivedPacket && dwReceivedPacketSize >= 4); assert(pEapOutput); diff --git a/lib/TTLS/include/Method.h b/lib/TTLS/include/Method.h index f599571..f5c66af 100644 --- a/lib/TTLS/include/Method.h +++ b/lib/TTLS/include/Method.h @@ -97,7 +97,7 @@ namespace eap virtual void process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput); + _Out_ EapPeerMethodOutput *pEapOutput); /// /// Obtains a response packet from the EAP method. diff --git a/lib/TTLS/include/Module.h b/lib/TTLS/include/Module.h index 5689f9e..64d950a 100644 --- a/lib/TTLS/include/Module.h +++ b/lib/TTLS/include/Module.h @@ -145,7 +145,7 @@ namespace eap _In_ EAP_SESSION_HANDLE hSession, _In_bytecount_(dwReceivedPacketSize) const EapPacket *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput); + _Out_ EapPeerMethodOutput *pEapOutput); /// /// Obtains a response packet from the EAP method. diff --git a/lib/TTLS/src/Method.cpp b/lib/TTLS/src/Method.cpp index eeb834f..1c9e3b2 100644 --- a/lib/TTLS/src/Method.cpp +++ b/lib/TTLS/src/Method.cpp @@ -92,7 +92,7 @@ void eap::method_ttls::end_session() void eap::method_ttls::process_request_packet( _In_bytecount_(dwReceivedPacketSize) const void *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput) + _Out_ EapPeerMethodOutput *pEapOutput) { if (((const EapPacket*)pReceivedPacket)->Code == EapCodeRequest && (((const EapPacket*)pReceivedPacket)->Data[1] & packet_ttls::flags_start)) { // This is a start EAP-TTLS packet. diff --git a/lib/TTLS/src/Module.cpp b/lib/TTLS/src/Module.cpp index e41d9b5..c094e09 100644 --- a/lib/TTLS/src/Module.cpp +++ b/lib/TTLS/src/Module.cpp @@ -251,7 +251,7 @@ void eap::peer_ttls::process_request_packet( _In_ EAP_SESSION_HANDLE hSession, _In_bytecount_(dwReceivedPacketSize) const EapPacket *pReceivedPacket, _In_ DWORD dwReceivedPacketSize, - _Inout_ EapPeerMethodOutput *pEapOutput) + _Out_ EapPeerMethodOutput *pEapOutput) { assert(dwReceivedPacketSize == ntohs(*(WORD*)pReceivedPacket->Length)); static_cast(hSession)->m_method->process_request_packet(pReceivedPacket, dwReceivedPacketSize, pEapOutput);