EapPeerMethodResult's fIsSuccess and dwFailureReasonCode management revised to guarantee configuration gets saved

This commit is contained in:
2016-09-06 09:57:34 +02:00
parent ff0b6c5ee4
commit b255aa6505
4 changed files with 7 additions and 25 deletions

View File

@@ -123,10 +123,6 @@ void eap::method_pap::get_result(
case EapPeerMethodResultSuccess: {
m_module.log_event(&EAPMETHOD_METHOD_SUCCESS, event_data((unsigned int)eap_type_legacy_pap), event_data::blank);
m_cfg.m_auth_failed = false;
ppResult->fIsSuccess = TRUE;
ppResult->dwFailureReasonCode = ERROR_SUCCESS;
break;
}
@@ -139,11 +135,6 @@ void eap::method_pap::get_result(
// But be careful: do so only after credentials were actually tried.
m_cfg.m_auth_failed = m_phase_prev < phase_finished && m_phase >= phase_finished;
// Do not report failure to EapHost, as it will not save updated configuration then. But we need it to save it, to alert user on next connection attempt.
// EapHost is well aware of the failed condition.
//ppResult->fIsSuccess = FALSE;
//ppResult->dwFailureReasonCode = EAP_E_AUTHENTICATION_FAILED;
break;
default: