Amebis/GEANTLink
Amebis/GEANTLink
1
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 50 Wiki Activity

method: Cleanup get_result()

Browse Source 
fIsSuccess is already set to TRUE by module::get_result().

Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman 2020-01-29 15:42:13 +01:00
parent b3291ff8b1
commit a2a4d75745
5 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/EapHost/src/Method.cpp
View File

@ -199,10 +199,8 @@ void eap::method_eaphost::get_result(
if (reason == EapPeerMethodResultSuccess) if (reason == EapPeerMethodResultSuccess)
m_cfg.m_last_status = config_method::status_t::success; m_cfg.m_last_status = config_method::status_t::success;
// Always ask EAP host to save the connection data. And it will save it *only* when we report "success". // Ask EAP host to save the configuration (connection data).
// Don't worry. EapHost is well aware of failed authentication condition.
pResult->fSaveConnectionData = TRUE; pResult->fSaveConnectionData = TRUE;
pResult->fIsSuccess = TRUE;
} else if (error) } else if (error)
throw eap_runtime_error(*error , __FUNCTION__ " EapHostPeerGetResult failed."); throw eap_runtime_error(*error , __FUNCTION__ " EapHostPeerGetResult failed.");
else else

4
lib/GTC/src/Method.cpp
View File

@ -130,10 +130,8 @@ void eap::method_gtc::get_result(
if (reason == EapPeerMethodResultSuccess) if (reason == EapPeerMethodResultSuccess)
m_cfg.m_last_status = config_method::status_t::success; m_cfg.m_last_status = config_method::status_t::success;
// Always ask EAP host to save the connection data. And it will save it *only* when we report "success". // Ask EAP host to save the configuration (connection data).
// Don't worry. EapHost is well aware of failed authentication condition.
pResult->fSaveConnectionData = TRUE; pResult->fSaveConnectionData = TRUE;
pResult->fIsSuccess = TRUE;
} }

4
lib/MSCHAPv2/src/Method.cpp
View File

@ -110,10 +110,8 @@ void eap::method_mschapv2_base::get_result(
if (reason == EapPeerMethodResultSuccess) if (reason == EapPeerMethodResultSuccess)
m_cfg.m_last_status = config_method::status_t::success; m_cfg.m_last_status = config_method::status_t::success;
// Always ask EAP host to save the connection data. And it will save it *only* when we report "success". // Ask EAP host to save the configuration (connection data).
// Don't worry. EapHost is well aware of failed authentication condition.
pResult->fSaveConnectionData = TRUE; pResult->fSaveConnectionData = TRUE;
pResult->fIsSuccess = TRUE;
} }

4
lib/PAP/src/Method.cpp
View File

@ -139,8 +139,6 @@ void eap::method_pap_diameter::get_result(
if (reason == EapPeerMethodResultSuccess) if (reason == EapPeerMethodResultSuccess)
m_cfg.m_last_status = config_method::status_t::success; m_cfg.m_last_status = config_method::status_t::success;
// Always ask EAP host to save the connection data. And it will save it *only* when we report "success". // Ask EAP host to save the configuration (connection data).
// Don't worry. EapHost is well aware of failed authentication condition.
pResult->fSaveConnectionData = TRUE; pResult->fSaveConnectionData = TRUE;
pResult->fIsSuccess = TRUE;
} }

4
lib/TTLS/src/Method.cpp
View File

@ -873,10 +873,8 @@ void eap::method_ttls::get_result(
dynamic_cast<peer_ttls&>(m_module).spawn_crl_check(std::move(m_sc_cert)); dynamic_cast<peer_ttls&>(m_module).spawn_crl_check(std::move(m_sc_cert));
} }
// Always ask EAP host to save the connection data. And it will save it *only* when we report "success". // Ask EAP host to save the configuration (connection data).
// Don't worry. EapHost is well aware of failed authentication condition.
pResult->fSaveConnectionData = TRUE; pResult->fSaveConnectionData = TRUE;
pResult->fIsSuccess = TRUE;
} }