Amebis/GEANTLink
1
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 50 Wiki Activity

Address code analysis warnings

Browse Source 
Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman
2019-08-22 20:44:38 +02:00
parent a459823beb
commit 6fb5cb88d2
60 changed files with 935 additions and 960 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/TTLS/include/Config.h
View File

@@ -69,7 +69,7 @@ namespace eap
///
/// \param[in] other Configuration to move from
///
config_method_ttls(_Inout_ config_method_ttls &&other);
config_method_ttls(_Inout_ config_method_ttls &&other) noexcept;
///
/// Copies configuration
@@ -87,7 +87,7 @@ namespace eap
///
/// \returns Reference to this object
///
config_method_ttls& operator=(_Inout_ config_method_ttls &&other);
config_method_ttls& operator=(_Inout_ config_method_ttls &&other) noexcept;
virtual config* clone() const;

6
lib/TTLS/include/Credentials.h
View File

@@ -62,7 +62,7 @@ namespace eap
///
/// \param[in] other Credentials to move from
///
credentials_ttls(_Inout_ credentials_ttls &&other);
credentials_ttls(_Inout_ credentials_ttls &&other) noexcept;
///
/// Copies credentials
@@ -80,7 +80,7 @@ namespace eap
///
/// \returns Reference to this object
///
credentials_ttls& operator=(_Inout_ credentials_ttls &&other);
credentials_ttls& operator=(_Inout_ credentials_ttls &&other) noexcept;
virtual config* clone() const;
virtual void clear();
@@ -127,7 +127,7 @@ namespace eap
///
virtual source_t combine(
_In_ DWORD dwFlags,
_In_ HANDLE hTokenImpersonateUser,
_In_opt_ HANDLE hTokenImpersonateUser,
_In_opt_ const credentials *cred_cached,
_In_ const config_method &cfg,
_In_opt_z_ LPCTSTR pszTargetName);

17
lib/TTLS/include/Method.h
View File

@@ -93,7 +93,7 @@ namespace eap
///
/// \param[in] other Method to move from
///
method_defrag(_Inout_ method_defrag &&other);
method_defrag(_Inout_ method_defrag &&other) noexcept;
///
/// Moves a method
@@ -102,7 +102,7 @@ namespace eap
///
/// \returns Reference to this object
///
method_defrag& operator=(_Inout_ method_defrag &&other);
method_defrag& operator=(_Inout_ method_defrag &&other) noexcept;
/// \name Session management
/// @{
@@ -129,7 +129,6 @@ namespace eap
/// @}
protected:
DWORD m_size_frag_max; ///< Maximum size of a fragment
sanitizing_blob m_data_req; ///< Data in request
sanitizing_blob m_data_res; ///< Data in response
bool m_send_res; ///< Are we sending a response?
@@ -156,7 +155,7 @@ namespace eap
///
/// \param[in] other Method to move from
///
method_eapmsg(_Inout_ method_eapmsg &&other);
method_eapmsg(_Inout_ method_eapmsg &&other) noexcept;
///
/// Moves a method
@@ -165,7 +164,7 @@ namespace eap
///
/// \returns Reference to this object
///
method_eapmsg& operator=(_Inout_ method_eapmsg &&other);
method_eapmsg& operator=(_Inout_ method_eapmsg &&other) noexcept;
/// \name Session management
/// @{
@@ -230,7 +229,7 @@ namespace eap
///
/// \param[in] other TTLS method to move from
///
method_ttls(_Inout_ method_ttls &&other);
method_ttls(_Inout_ method_ttls &&other) noexcept;
///
/// Moves a TTLS method
@@ -239,7 +238,7 @@ namespace eap
///
/// \returns Reference to this object
///
method_ttls& operator=(_Inout_ method_ttls &&other);
method_ttls& operator=(_Inout_ method_ttls &&other) noexcept;
/// \name Session management
/// @{
@@ -266,8 +265,8 @@ namespace eap
/// @}
virtual void get_result(
_In_ EapPeerMethodResultReason reason,
_Out_ EapPeerMethodResult *pResult);
_In_ EapPeerMethodResultReason reason,
_Inout_ EapPeerMethodResult *pResult);
protected:
#if EAP_TLS < EAP_TLS_SCHANNEL_FULL

20
lib/TTLS/include/Module.h
View File

@@ -115,16 +115,16 @@ namespace eap
_Out_ EapPeerMethodOutput *pEapOutput);
virtual void get_response_packet(
_In_ EAP_SESSION_HANDLE hSession,
_Inout_bytecap_(*dwSendPacketSize) EapPacket *pSendPacket,
_Inout_ DWORD *pdwSendPacketSize);
_In_ EAP_SESSION_HANDLE hSession,
_Out_bytecapcount_(*pdwSendPacketSize) EapPacket *pSendPacket,
_Inout_ DWORD *pdwSendPacketSize);
/// @}
virtual void get_result(
_In_ EAP_SESSION_HANDLE hSession,
_In_ EapPeerMethodResultReason reason,
_Out_ EapPeerMethodResult *pResult);
_In_ EAP_SESSION_HANDLE hSession,
_In_ EapPeerMethodResultReason reason,
_Inout_ EapPeerMethodResult *pResult);
/// \name User Interaction
/// @{
@@ -167,12 +167,12 @@ namespace eap
///
/// Checks all configured providers and tries to combine credentials.
///
const config_method_ttls* combine_credentials(
_Success_(return != 0) const config_method_ttls* combine_credentials(
_In_ DWORD dwFlags,
_In_ const config_connection &cfg,
_In_count_(dwUserDataSize) const BYTE *pUserData,
_In_ DWORD dwUserDataSize,
_Out_ credentials_connection& cred_out,
_Inout_ credentials_connection& cred_out,
_In_ HANDLE hTokenImpersonateUser);
protected:
@@ -223,7 +223,7 @@ namespace eap
///
/// \param[in] other Thread to move from
///
crl_checker(_Inout_ crl_checker &&other);
crl_checker(_Inout_ crl_checker &&other) noexcept;
///
/// Moves a thread
@@ -232,7 +232,7 @@ namespace eap
///
/// \returns Reference to this object
///
crl_checker& operator=(_Inout_ crl_checker &&other);
crl_checker& operator=(_Inout_ crl_checker &&other) noexcept;
///
/// Verifies server's certificate if it has been revoked

4
lib/TTLS/include/UIContext.h
View File

@@ -61,7 +61,7 @@ namespace eap
///
/// \param[in] other Credentials to move from
///
ui_context_ttls(_Inout_ ui_context_ttls &&other);
ui_context_ttls(_Inout_ ui_context_ttls &&other) noexcept;
///
/// Copies context
@@ -79,7 +79,7 @@ namespace eap
///
/// \returns Reference to this object
///
ui_context_ttls& operator=(_Inout_ ui_context_ttls &&other);
ui_context_ttls& operator=(_Inout_ ui_context_ttls &&other) noexcept;
/// \name BLOB management
/// @{