Amebis/GEANTLink
1
1
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 50 Wiki Activity

Address code analysis warnings

Browse Source 
Signed-off-by: Simon Rozman <simon@rozman.si>
This commit is contained in:
Simon Rozman
2019-08-22 20:44:38 +02:00
parent a459823beb
commit 6fb5cb88d2
60 changed files with 935 additions and 960 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/GTC/include/Config.h
View File

@@ -74,7 +74,7 @@ namespace eap
///
/// \param[in] other Configuration to move from
///
config_method_eapgtc(_Inout_ config_method_eapgtc &&other);
config_method_eapgtc(_Inout_ config_method_eapgtc &&other) noexcept;
///
/// Copies configuration
@@ -92,7 +92,7 @@ namespace eap
///
/// \returns Reference to this object
///
config_method_eapgtc& operator=(_Inout_ config_method_eapgtc &&other);
config_method_eapgtc& operator=(_Inout_ config_method_eapgtc &&other) noexcept;
virtual config* clone() const;

8
lib/GTC/include/Method.h
View File

@@ -57,7 +57,7 @@ namespace eap
///
/// \param[in] other GTC method to move from
///
method_gtc(_Inout_ method_gtc &&other);
method_gtc(_Inout_ method_gtc &&other) noexcept;
///
/// Moves a GTC method
@@ -66,7 +66,7 @@ namespace eap
///
/// \returns Reference to this object
///
method_gtc& operator=(_Inout_ method_gtc &&other);
method_gtc& operator=(_Inout_ method_gtc &&other) noexcept;
/// \name Session management
/// @{
@@ -93,8 +93,8 @@ namespace eap
/// @}
virtual void get_result(
_In_ EapPeerMethodResultReason reason,
_Out_ EapPeerMethodResult *pResult);
_In_ EapPeerMethodResultReason reason,
_Inout_ EapPeerMethodResult *pResult);
/// \name User Interaction
/// @{

4
lib/GTC/src/Config.cpp
View File

@@ -41,7 +41,7 @@ eap::config_method_eapgtc::config_method_eapgtc(_In_ const config_method_eapgtc
}
eap::config_method_eapgtc::config_method_eapgtc(_Inout_ config_method_eapgtc &&other) :
eap::config_method_eapgtc::config_method_eapgtc(_Inout_ config_method_eapgtc &&other) noexcept :
config_method_with_cred(std::move(other))
{
}
@@ -56,7 +56,7 @@ eap::config_method_eapgtc& eap::config_method_eapgtc::operator=(_In_ const confi
}
eap::config_method_eapgtc& eap::config_method_eapgtc::operator=(_Inout_ config_method_eapgtc &&other)
eap::config_method_eapgtc& eap::config_method_eapgtc::operator=(_Inout_ config_method_eapgtc &&other) noexcept
{
if (this != &other)
(config_method_with_cred&&)*this = std::move(other);

6
lib/GTC/src/Method.cpp
View File

@@ -36,7 +36,7 @@ eap::method_gtc::method_gtc(_In_ module &mod, _In_ config_method_eapgtc &cfg, _I
}
eap::method_gtc::method_gtc(_Inout_ method_gtc &&other) :
eap::method_gtc::method_gtc(_Inout_ method_gtc &&other) noexcept :
m_cfg ( other.m_cfg ),
m_cred ( other.m_cred ),
m_challenge(std::move(other.m_challenge)),
@@ -46,7 +46,7 @@ eap::method_gtc::method_gtc(_Inout_ method_gtc &&other) :
}
eap::method_gtc& eap::method_gtc::operator=(_Inout_ method_gtc &&other)
eap::method_gtc& eap::method_gtc::operator=(_Inout_ method_gtc &&other) noexcept
{
if (this != std::addressof(other)) {
assert(std::addressof(m_cfg ) == std::addressof(other.m_cfg )); // Move method within same configuration only!
@@ -113,7 +113,7 @@ void eap::method_gtc::get_response_packet(
WideCharToMultiByte(CP_UTF8, 0, m_response, response_utf8, NULL, NULL);
if (sizeof(sanitizing_string::value_type)*response_utf8.length() > size_max)
throw invalid_argument(string_printf(__FUNCTION__ " This method does not support packet fragmentation, but the data size is too big to fit in one packet (packet: %u, maximum: %u).", sizeof(sanitizing_string::value_type)*response_utf8.length(), size_max));
throw invalid_argument(string_printf(__FUNCTION__ " This method does not support packet fragmentation, but the data size is too big to fit in one packet (packet: %zu, maximum: %u).", sizeof(sanitizing_string::value_type)*response_utf8.length(), size_max));
packet.assign(response_utf8.begin(), response_utf8.end());
}