4467fab2a8
Put back horizontal scrolling option again
...
DOM document is 2-dimensional! What applies to one dimension, may apply
to another too. Never assume we're scrolling texts vertically only.
2024-06-10 15:01:10 +02:00
ba9a18705e
Merge commit 'e8b1ab94d9ae1a26152f7b4ebaafd7b12480dbb3'
2024-06-10 14:53:46 +02:00
f5257f1872
Fix&finish mistake highlight rect management
...
Proposed solution was not complete, match.highlights is not an array
without a good reason, so checking only match.highlights[0] is never
a good idea. Should a grammar mistake wrap across more lines of text,
match.highlights gets one element per each part of the _same_ grammar
that spans one line of text. By not checking them all, popup failed
to appear when clicking on a grammar mistake following on the next line
of text.
Furthermore, the solution only addressed BesTreeService.onClick(), while
the same logic should be applied to BesPlainTextService.onClick() too.
2024-06-10 14:50:54 +02:00
55a075b927
Merge commit '159cd516846b196fd13c640d28d55b0821bbbdb3'
2024-06-10 14:50:27 +02:00
efc0009301
Put back horizontal scrolling option
...
DOM document is 2-dimensional! What applies to one dimension, may apply
to another too. Never assume we're scrolling texts vertically only.
2024-06-10 14:49:06 +02:00
edbe39722f
Refactor ruleType logic to make it accessible within other besService subclasses
2024-06-05 10:18:55 +02:00
54ba1dea33
Push ruleType into matches object, since it is needed later to correctly reposition markup
2024-06-05 09:47:57 +02:00
81d60bd37e
Add distinct highlighting for various error types
2024-06-05 09:15:28 +02:00
7a72474cd3
Solve an issue where the highlight rectangles were split across separate lines.
2024-06-04 09:37:55 +02:00
32f4360de9
Implement debouncing to optimize text error handling
...
Previously, texts with numerous errors could cause performance issues due to the high frequency of function calls. With the new debouncing implementation, we effectively limit the rate at which the error handling function executes, thereby reducing potential lagginess and improving the overall user experience.
2024-06-03 10:49:34 +02:00
a23dea067c
Enhance visual appearance of popup element
2024-05-30 09:03:54 +02:00
e8b1ab94d9
Improve status div positioning
2024-05-30 07:49:51 +02:00
953d0ef548
Create a mock page for DOM changes
2024-05-24 16:55:25 +02:00
7cf139ddaa
Remove a redundant comment
2024-05-24 16:52:58 +02:00
159cd51684
Improve the logic for repositioning grammar mistake highlights in response to DOM changes
...
Refactor the click detection logic to check if the click was inside the rectangle of the highlight element, rather than relying on stored rectangle coordinates.
Additionally, this update eliminates the need to attach event listeners to the entire window or the parent elements of the host element, simplifying the event handling and potentially improving performance.
2024-05-24 16:48:02 +02:00
94847d44f2
Update TODO comment
2024-05-24 11:11:57 +02:00
31934aa2c5
Optimize scroll event handling by limiting updates to rect positions only
2024-05-24 11:07:55 +02:00
76ba7788c0
Resolve overflow on X-axis issue and reimplement onScroll event listener
2024-05-24 10:13:12 +02:00
033b56329f
Disable grammarly extension on host element
2024-05-24 08:50:24 +02:00
5871f38f26
Find a way to correctly position statusDiv element inside CKEditor.
2024-05-23 14:20:59 +02:00
94f55e0d7f
service2.js: Revise
2024-05-23 12:35:12 +02:00
947d5048e6
service2.js: Remove resolved TODO
2024-05-23 12:17:34 +02:00
9258cecc73
service2.js: Reintroduce window resize event listening
...
This is an emergency solution to track host element position changing.
2024-05-23 12:16:54 +02:00
cb0f55a976
service2.js: Remove excessive markup repositioning
...
When window scrolls, our host element, correction panel and status icon
don't change their (left, top, right, bottom) document coordinates.
2024-05-23 12:08:17 +02:00
85d8f42dba
service2.js: Simplify
2024-05-23 12:05:37 +02:00
273c96b78c
service2.js: Mind horizontal scrolling, padding and margins too
2024-05-23 11:12:46 +02:00
06513cab05
Reinstate setTimeout function in CKEditor to ensure proper handling of instances where a specific height value is assigned to the editable element
2024-05-22 14:22:16 +02:00
afd9709ef5
Fix statusDiv position
...
This position needs to be tested on high resolution displays (4K, etc.)
2024-05-22 14:15:06 +02:00
f3ee5d1d37
Add an option to detach event listener and retrieve original spellcheck attribute
2024-05-22 14:08:37 +02:00
6784df431c
Eliminate unnecessary setTimeout function from CKEditor's class, since it is no longer needed
2024-05-22 13:36:08 +02:00
21eaa95130
Implement ResizeObserver to observe resizing in host elements
2024-05-22 13:31:54 +02:00
89201ceaff
service2.js: Port CKEditor service
2024-05-22 12:52:23 +02:00
e0e9f1a651
service2.js: Fix empty paragraph handling
2024-05-22 11:03:54 +02:00
6eac44165f
service2.js: Move reusable correction panel handling upstream
2024-05-22 11:03:19 +02:00
0e7e324694
service2.js: Unify equal/same comparisons
2024-05-22 09:47:24 +02:00
5f83dfa4ba
service2.js: Add contenteditable=plaintext-only support
2024-05-21 18:32:30 +02:00
478f6269ee
service2.js: Remove excessive clearProofing() call
...
The markProofed() is called for block elements not proofed == not
present in this.results. Hence, clearProofing() has no effect in
markProofed().
2024-05-21 18:31:54 +02:00
49dc3385ea
service2.js: Fix onFailedProofingResult not called on abort
2024-05-21 18:30:04 +02:00
67eee1015e
service2.js: Fix corner cases and prepare for plain-text services
2024-05-21 11:43:52 +02:00
e05abce7d9
service2.js: Fix status icon and port status popup
...
However, status popup was disabled as deemed excessive for our use case.
2024-05-15 12:28:15 +02:00
5e339566f3
service2.js: Move abortController management upstream
...
Generally, any gramar checking will be cancellable and will need this.
2024-05-15 12:28:15 +02:00
ff54607e7e
service2.js: Port popup from service.js
2024-05-15 12:28:15 +02:00
c54366e95f
Refactor CKEditor event handling
2024-05-14 13:33:01 +02:00
970b43b8d6
Improve handling CKEditor events from plugins
2024-05-13 09:55:27 +02:00
133a278c9c
service2: Rework proofing notifications and aborting
...
Notifications were inconsistent in case of errors while checking
grammar.
2024-05-10 15:38:53 +02:00
e499ad22f8
Fork service2.js
...
Due to intensive development, service.js grew complex and convoluted.
With lessons learned we shall prepare a cleaner and leaner version of
the code.
2024-05-10 14:23:58 +02:00
d15348ed50
Extend updateStatusIcon() to set title too
...
All calls to updateStatusIcon() were followed by setting the title.
2024-05-08 13:15:10 +02:00
d6e823ed7a
Refactor proof() to remove isInitialCall requirement
...
Let's keep now recursiveProof() as clean as possible.
2024-05-08 13:09:12 +02:00
6392328e98
Add missing parameter documentation
2024-05-08 12:50:10 +02:00
71d17273d0
Cleanup excessive documentation
2024-05-08 12:29:43 +02:00
