Amebis/BesService
2
2
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'remotes/origin/master'

Browse Source
This commit is contained in:
Simon Rozman 2024-06-10 16:00:54 +02:00
commit a23037d23a
2 changed files with 34 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
service2.js
View File

@ -48,6 +48,16 @@ class BesService {
this.resizeObserver = new ResizeObserver(this.onResize.bind(this)) this.resizeObserver = new ResizeObserver(this.onResize.bind(this))
this.resizeObserver.observe(this.hostElement) this.resizeObserver.observe(this.hostElement)
// TODO: Include missing rules
// Initial user feedback indicated a requirement for clear differentiation between spelling and grammar errors.
this.ruleTypes = {
BESANA_1: 'bes-spelling-mistake',
BESANA_2: 'bes-spelling-mistake',
BESANA_3: 'bes-spelling-mistake',
BESANA_4: 'bes-grammar-mistake',
BESANA_5: 'bes-spelling-mistake'
}
besServices.push(this) besServices.push(this)
} }
@ -176,12 +186,12 @@ class BesService {
* @param {Range} range Grammar mistake range * @param {Range} range Grammar mistake range
* @returns {Array} Grammar mistake highlight elements * @returns {Array} Grammar mistake highlight elements
*/ */
addMistakeMarkup(range) { addMistakeMarkup(range, ruleType) {
const scrollPanelRect = this.scrollPanel.getBoundingClientRect() const scrollPanelRect = this.scrollPanel.getBoundingClientRect()
let highlights = [] let highlights = []
for (let rect of range.getClientRects()) { for (let rect of range.getClientRects()) {
const highlight = document.createElement('div') const highlight = document.createElement('div')
highlight.classList.add('bes-typo-mistake') highlight.classList.add(ruleType)
highlight.style.left = `${rect.left - scrollPanelRect.left}px` highlight.style.left = `${rect.left - scrollPanelRect.left}px`
highlight.style.top = `${rect.top - scrollPanelRect.top}px` highlight.style.top = `${rect.top - scrollPanelRect.top}px`
highlight.style.width = `${rect.width}px` highlight.style.width = `${rect.width}px`
@ -472,10 +482,13 @@ class BesTreeService extends BesService {
} }
} }
const ruleType =
this.ruleTypes[match.rule.id] || 'bes-spelling-mistake'
matches.push({ matches.push({
highlights: this.addMistakeMarkup(range), highlights: this.addMistakeMarkup(range, ruleType),
range: range, range: range,
match: match match: match,
ruleType: ruleType
}) })
}) })
this.markProofed(node, matches) this.markProofed(node, matches)
@ -541,7 +554,7 @@ class BesTreeService extends BesService {
this.results.forEach(result => { this.results.forEach(result => {
result.matches.forEach(match => { result.matches.forEach(match => {
if (match.highlights) match.highlights.forEach(h => h.remove()) if (match.highlights) match.highlights.forEach(h => h.remove())
match.highlights = this.addMistakeMarkup(match.range) match.highlights = this.addMistakeMarkup(match.range, match.ruleType)
}) })
}) })
} }
@ -1177,10 +1190,13 @@ class BesPlainTextService extends BesService {
nodes[nodeIdx].node, nodes[nodeIdx].node,
matchEnd - nodes[nodeIdx].start matchEnd - nodes[nodeIdx].start
) )
const ruleType =
this.ruleTypes[match.rule.id] || 'bes-spelling-mistake'
matches.push({ matches.push({
highlights: this.addMistakeMarkup(matchRange), highlights: this.addMistakeMarkup(matchRange, ruleType),
range: matchRange, range: matchRange,
match: match match: match,
ruleType: ruleType
}) })
}) })
this.markProofed(paragraphRange, matches) this.markProofed(paragraphRange, matches)
@ -1260,7 +1276,7 @@ class BesPlainTextService extends BesService {
this.results.forEach(result => { this.results.forEach(result => {
result.matches.forEach(match => { result.matches.forEach(match => {
if (match.highlights) match.highlights.forEach(h => h.remove()) if (match.highlights) match.highlights.forEach(h => h.remove())
match.highlights = this.addMistakeMarkup(match.range) match.highlights = this.addMistakeMarkup(match.range, match.ruleType)
}) })
}) })
} }

13
styles.css
View File

@ -1,14 +1,21 @@
/* TODO: Dark mode theme */ /* TODO: Dark mode theme */
/* Mistake types styles */ /* Mistake types styles */
.bes-typo-mistake { .bes-spelling-mistake {
border-bottom: 2px solid red; border-bottom: 2px solid #ff7300;
position: absolute; position: absolute;
z-index: 3; z-index: 3;
cursor: text; cursor: text;
/* pointer-events: none; */
} }
.bes-grammar-mistake {
border-bottom: 2px solid #007bff;
position: absolute;
z-index: 3;
cursor: text;
}
/* Styles required to ensure full functionality and optimal user experience. */
.bes-correction-panel-parent { .bes-correction-panel-parent {
position: relative; position: relative;
overflow: visible; overflow: visible;