Amebis/BesService
2
2
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Add a comment about possible performance issues

Browse Source
This commit is contained in:
Aljaž Grilc 2024-04-10 09:50:41 +02:00
parent cf8bc8afbd
commit 6aaa8c4472
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
service.js
View File

@ -254,8 +254,7 @@ class BesService {
BesService.getNodesInRange(range).forEach(el => { BesService.getNodesInRange(range).forEach(el => {
if ( if (
el === hostElement || el === hostElement ||
Array.from(hostElement.childNodes).includes(el) || Array.from(hostElement.childNodes).includes(el)
hostElement.contains(el)
) { ) {
blockElements.add(service.getBlockParent(el)) blockElements.add(service.getBlockParent(el))
} }
@ -266,6 +265,8 @@ class BesService {
service.removeChild(block) service.removeChild(block)
}) })
// Not a nice way to do it, but it works for now the repositionMistakes function is called before the DOM updates are finished. // Not a nice way to do it, but it works for now the repositionMistakes function is called before the DOM updates are finished.
// If users will experience performance issues, we can consider debouncing this function.
// The lagginess becomes noticeable if the text is long and has many grammar mistakes.
setTimeout(() => { setTimeout(() => {
service.repositionMistakes() service.repositionMistakes()
}, 0) }, 0)