From 16e85f5498c0e58c8819e3916140ec714043948e Mon Sep 17 00:00:00 2001 From: Simon Rozman Date: Thu, 27 Feb 2025 16:03:45 +0100 Subject: [PATCH] Fix unregister cleanup --- service.js | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/service.js b/service.js index f85d72d..27c2144 100644 --- a/service.js +++ b/service.js @@ -840,8 +840,8 @@ class BesService { * Creates auxiliary DOM elements for text adornments. */ createCorrectionPanel() { - const panelParent = document.createElement('div') - panelParent.classList.add('bes-correction-panel-parent') + this.panelParent = document.createElement('div') + this.panelParent.classList.add('bes-correction-panel-parent') this.correctionPanel = document.createElement('div') this.correctionPanel.classList.add('bes-correction-panel') @@ -851,9 +851,12 @@ class BesService { this.ctx = this.canvasPanel.getContext('2d') this.ctx.scale(1, 1) - panelParent.appendChild(this.correctionPanel) + this.panelParent.appendChild(this.correctionPanel) this.correctionPanel.appendChild(this.canvasPanel) - this.textElement.parentElement.insertBefore(panelParent, this.textElement) + this.textElement.parentElement.insertBefore( + this.panelParent, + this.textElement + ) this.setCorrectionPanelSize() } @@ -861,8 +864,7 @@ class BesService { * Clears auxiliary DOM elements for text adornments. */ clearCorrectionPanel() { - this.correctionPanel.remove() - this.canvasPanel.remove() + this.panelParent.remove() } /** @@ -2243,6 +2245,14 @@ class BesTAService extends BesPlainTextService { return service } + /** + * Unregisters grammar checking service. + */ + unregister() { + super.unregister() + this.textElement.remove() + } + /** * Creates a clone div element for the