Amebis/BesService
2
2
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use scrollintoView after using shortcut navigation for finding a next/previous mistake #4

Browse Source
This commit is contained in:
Aljaž Grilc 2025-06-05 08:11:42 +02:00
parent 1163b3c47e
commit 04cd5f2e7d
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
service.js
View File

@ -336,8 +336,6 @@ class BesService {
* @param {Event} e * @param {Event} e
*/ */
onShortcutNavigation(e) { onShortcutNavigation(e) {
//TODO: If no highlightElement is selected? find the first mistake that comes after cursor and move to it.
if (!this.highlightElements.length) return
switch (e.code) { switch (e.code) {
case 'BracketLeft': case 'BracketLeft':
if (e.ctrlKey) { if (e.ctrlKey) {
@ -1195,7 +1193,9 @@ class BesService {
this.activeMatchIndex = next this.activeMatchIndex = next
const { el, match } = this.sortedMatches[next] const { el, match } = this.sortedMatches[next]
// TODO: find out why scrollintoview does not work well // Not the cleanest solution, but it is good enough for now
el.scrollIntoView({ behavior: 'instant' })
setTimeout(() => {
this.dismissPopup() this.dismissPopup()
const popup = document.querySelector('bes-popup-el') const popup = document.querySelector('bes-popup-el')
BesPopup.clearReplacements() BesPopup.clearReplacements()
@ -1205,6 +1205,7 @@ class BesService {
const clientY = `${el.y + 150}` const clientY = `${el.y + 150}`
popup.show(el.x, clientY, this) popup.show(el.x, clientY, this)
}) })
}, 150)
} }
/** /**